Skip to content

Commit 4130c43

Browse files
committed
os/bluestore: rename bluefs_super_t::version -> seq
Signed-off-by: Igor Fedotov <[email protected]>
1 parent d6a2d37 commit 4130c43

File tree

3 files changed

+12
-12
lines changed

3 files changed

+12
-12
lines changed

src/os/bluestore/BlueFS.cc

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -702,7 +702,7 @@ int BlueFS::mkfs(uuid_d osd_uuid, const bluefs_layout_t& layout)
702702

703703
_init_logger();
704704

705-
super.version = 0;
705+
super.seq = 0;
706706
super.block_size = bdev[BDEV_DB]->get_block_size();
707707
super.osd_uuid = osd_uuid;
708708
super.uuid.generate_random();
@@ -1215,20 +1215,20 @@ int BlueFS::fsck()
12151215

12161216
int BlueFS::_write_super(int dev)
12171217
{
1218-
++super.version;
1218+
++super.seq;
12191219
// build superblock
12201220
bufferlist bl;
12211221
encode(super, bl);
12221222
uint32_t crc = bl.crc32c(-1);
12231223
encode(crc, bl);
12241224
dout(10) << __func__ << " super block length(encoded): " << bl.length() << dendl;
1225-
dout(10) << __func__ << " superblock " << super.version << dendl;
1225+
dout(10) << __func__ << " superblock " << super.seq << dendl;
12261226
dout(10) << __func__ << " log_fnode " << super.log_fnode << dendl;
12271227
ceph_assert_always(bl.length() <= get_super_length());
12281228
bl.append_zero(get_super_length() - bl.length());
12291229

12301230
bdev[dev]->write(get_super_offset(), bl, false, WRITE_LIFE_SHORT);
1231-
dout(20) << __func__ << " v " << super.version
1231+
dout(20) << __func__ << " seq " << super.seq
12321232
<< " crc 0x" << std::hex << crc
12331233
<< " offset 0x" << get_super_offset() << std::dec
12341234
<< dendl;
@@ -1263,7 +1263,7 @@ int BlueFS::_open_super()
12631263
<< dendl;
12641264
return -EIO;
12651265
}
1266-
dout(10) << __func__ << " superblock " << super.version << dendl;
1266+
dout(10) << __func__ << " superblock " << super.seq << dendl;
12671267
dout(10) << __func__ << " log_fnode " << super.log_fnode << dendl;
12681268
return 0;
12691269
}

src/os/bluestore/bluefs_types.cc

Lines changed: 6 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -75,15 +75,15 @@ void bluefs_layout_t::generate_test_instances(list<bluefs_layout_t*>& ls)
7575
}
7676

7777
// bluefs_super_t
78-
bluefs_super_t::bluefs_super_t() : version(0), block_size(4096) {
78+
bluefs_super_t::bluefs_super_t() : seq(0), block_size(4096) {
7979
}
8080

8181
void bluefs_super_t::encode(bufferlist& bl) const
8282
{
8383
ENCODE_START(2, 1, bl);
8484
encode(uuid, bl);
8585
encode(osd_uuid, bl);
86-
encode(version, bl);
86+
encode(seq, bl);
8787
encode(block_size, bl);
8888
encode(log_fnode, bl);
8989
encode(memorized_layout, bl);
@@ -95,7 +95,7 @@ void bluefs_super_t::decode(bufferlist::const_iterator& p)
9595
DECODE_START(2, p);
9696
decode(uuid, p);
9797
decode(osd_uuid, p);
98-
decode(version, p);
98+
decode(seq, p);
9999
decode(block_size, p);
100100
decode(log_fnode, p);
101101
if (struct_v >= 2) {
@@ -108,7 +108,7 @@ void bluefs_super_t::dump(Formatter *f) const
108108
{
109109
f->dump_stream("uuid") << uuid;
110110
f->dump_stream("osd_uuid") << osd_uuid;
111-
f->dump_unsigned("version", version);
111+
f->dump_unsigned("seq", seq);
112112
f->dump_unsigned("block_size", block_size);
113113
f->dump_object("log_fnode", log_fnode);
114114
}
@@ -117,15 +117,15 @@ void bluefs_super_t::generate_test_instances(list<bluefs_super_t*>& ls)
117117
{
118118
ls.push_back(new bluefs_super_t);
119119
ls.push_back(new bluefs_super_t);
120-
ls.back()->version = 1;
120+
ls.back()->seq = 1;
121121
ls.back()->block_size = 4096;
122122
}
123123

124124
ostream& operator<<(ostream& out, const bluefs_super_t& s)
125125
{
126126
return out << "super(uuid " << s.uuid
127127
<< " osd " << s.osd_uuid
128-
<< " v " << s.version
128+
<< " seq " << s.seq
129129
<< " block_size 0x" << std::hex << s.block_size
130130
<< " log_fnode 0x" << s.log_fnode
131131
<< std::dec << ")";

src/os/bluestore/bluefs_types.h

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -213,7 +213,7 @@ WRITE_CLASS_ENCODER(bluefs_layout_t)
213213
struct bluefs_super_t {
214214
uuid_d uuid; ///< unique to this bluefs instance
215215
uuid_d osd_uuid; ///< matches the osd that owns us
216-
uint64_t version; ///< In fact that's update counter
216+
uint64_t seq; ///< sequence counter
217217
uint32_t block_size;
218218

219219
bluefs_fnode_t log_fnode;

0 commit comments

Comments
 (0)