Skip to content

Commit 44a1eb5

Browse files
authored
Merge pull request ceph#62343 from VallariAg/wip-nvmeof-prometheus-singlegateway-rename
monitoring: rename NVMeoFSingleGatewayGroup alert
2 parents 70172f7 + 82ec00d commit 44a1eb5

File tree

3 files changed

+4
-4
lines changed

3 files changed

+4
-4
lines changed

monitoring/ceph-mixin/prometheus_alerts.libsonnet

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -896,7 +896,7 @@
896896
},
897897
},
898898
{
899-
alert: 'NVMeoFSingleGatewayGroup',
899+
alert: 'NVMeoFSingleGateway',
900900
'for': '5m',
901901
expr: 'count(ceph_nvmeof_gateway_info) by(cluster,group) == 1',
902902
labels: { severity: 'warning', type: 'ceph_default' },

monitoring/ceph-mixin/prometheus_alerts.yml

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -801,7 +801,7 @@ groups:
801801
labels:
802802
severity: "warning"
803803
type: "ceph_default"
804-
- alert: "NVMeoFSingleGatewayGroup"
804+
- alert: "NVMeoFSingleGateway"
805805
annotations:
806806
description: "Although a single member gateway group is valid, it should only be used for test purposes"
807807
summary: "The gateway group {{ $labels.group }} consists of a single gateway - HA is not possible on cluster {{ $labels.cluster }}"

monitoring/ceph-mixin/tests_alerts/test_alerts.yml

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -2482,7 +2482,7 @@ tests:
24822482
summary: "Max gateway groups exceeded on cluster mycluster"
24832483
description: "You may create many gateway groups, but 4 is the tested limit"
24842484

2485-
# NVMeoFSingleGatewayGroup
2485+
# NVMeoFSingleGateway
24862486
- interval: 1m
24872487
input_series:
24882488
- series: 'ceph_nvmeof_gateway_info{group="group-1",addr="1.1.1.2",cluster="mycluster"}'
@@ -2499,7 +2499,7 @@ tests:
24992499
value: 1
25002500
alert_rule_test:
25012501
- eval_time: 5m
2502-
alertname: NVMeoFSingleGatewayGroup
2502+
alertname: NVMeoFSingleGateway
25032503
exp_alerts:
25042504
- exp_labels:
25052505
group: group-1

0 commit comments

Comments
 (0)