Skip to content

Commit 59f73a5

Browse files
committed
rgw: Don't print spurious error on radosgw-admin exit
When debugging crashes related to `RGWDataChangesLog` shutdown, I fixed the crashes, but broke the logic that decides whether to print the error. Fixes: https://tracker.ceph.com/issues/70864 Signed-off-by: Adam C. Emerson <[email protected]>
1 parent 627a12f commit 59f73a5

File tree

1 file changed

+4
-1
lines changed

1 file changed

+4
-1
lines changed

src/rgw/driver/rados/rgw_datalog.cc

Lines changed: 4 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1357,10 +1357,13 @@ bool RGWDataChangesLog::going_down() const
13571357

13581358
asio::awaitable<void> RGWDataChangesLog::shutdown() {
13591359
DoutPrefix dp{cct, ceph_subsys_rgw, "Datalog Shutdown"};
1360-
if (down_flag || !ran_background) {
1360+
if (down_flag) {
13611361
co_return;
13621362
}
13631363
down_flag = true;
1364+
if (!ran_background) {
1365+
co_return;
1366+
}
13641367
renew_stop();
13651368
// Revisit this later
13661369
if (renew_signal)

0 commit comments

Comments
 (0)