Skip to content

Commit 6036944

Browse files
committed
crimson/os/seastore/lba_manager: drop unused get_mappings()
Signed-off-by: Yingxin Cheng <[email protected]>
1 parent 6ac0621 commit 6036944

File tree

3 files changed

+0
-41
lines changed

3 files changed

+0
-41
lines changed

src/crimson/os/seastore/lba_manager.h

Lines changed: 0 additions & 11 deletions
Original file line numberDiff line numberDiff line change
@@ -50,17 +50,6 @@ class LBAManager {
5050
Transaction &t,
5151
laddr_t offset, extent_len_t length) = 0;
5252

53-
/**
54-
* Fetches mappings for a list of laddr_t in range [offset, offset + len)
55-
*
56-
* Future will not resolve until all pins have resolved (set_paddr called)
57-
* For indirect lba mappings, get_mappings will always retrieve the original
58-
* lba value.
59-
*/
60-
virtual get_mappings_ret get_mappings(
61-
Transaction &t,
62-
laddr_list_t &&extent_lisk) = 0;
63-
6453
/**
6554
* Fetches the mapping for laddr_t
6655
*

src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.cc

Lines changed: 0 additions & 25 deletions
Original file line numberDiff line numberDiff line change
@@ -242,31 +242,6 @@ BtreeLBAManager::_get_original_mappings(
242242
});
243243
}
244244

245-
246-
BtreeLBAManager::get_mappings_ret
247-
BtreeLBAManager::get_mappings(
248-
Transaction &t,
249-
laddr_list_t &&list)
250-
{
251-
LOG_PREFIX(BtreeLBAManager::get_mappings);
252-
TRACET("{}", t, list);
253-
auto l = std::make_unique<laddr_list_t>(std::move(list));
254-
auto retptr = std::make_unique<lba_pin_list_t>();
255-
auto &ret = *retptr;
256-
return trans_intr::do_for_each(
257-
l->begin(),
258-
l->end(),
259-
[this, &t, &ret](const auto &p) {
260-
return this->get_mappings(t, p.first, p.second).si_then(
261-
[&ret](auto res) {
262-
ret.splice(ret.end(), res, res.begin(), res.end());
263-
return get_mappings_iertr::now();
264-
});
265-
}).si_then([l=std::move(l), retptr=std::move(retptr)]() mutable {
266-
return std::move(*retptr);
267-
});
268-
}
269-
270245
BtreeLBAManager::get_mapping_ret
271246
BtreeLBAManager::get_mapping(
272247
Transaction &t,

src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h

Lines changed: 0 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -269,15 +269,10 @@ class BtreeLBAManager : public LBAManager {
269269
Transaction &t,
270270
laddr_t offset, extent_len_t length) final;
271271

272-
get_mappings_ret get_mappings(
273-
Transaction &t,
274-
laddr_list_t &&list) final;
275-
276272
get_mapping_ret get_mapping(
277273
Transaction &t,
278274
laddr_t offset) final;
279275

280-
281276
struct alloc_mapping_info_t {
282277
laddr_t key = L_ADDR_NULL; // once assigned, the allocation to
283278
// key must be exact and successful

0 commit comments

Comments
 (0)