Skip to content

Commit 72f06fc

Browse files
authored
Merge pull request ceph#62566 from tchaikov/neorados-googletest
neorados/test, googletest: adapt to googletest and bump up googletest submodule Reviewed-by: Adam Emerson <[email protected]>
2 parents 54eda98 + 986f691 commit 72f06fc

File tree

3 files changed

+5
-8
lines changed

3 files changed

+5
-8
lines changed

src/CMakeLists.txt

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -764,7 +764,7 @@ add_subdirectory(erasure-code)
764764
if(WITH_TESTS)
765765
option(WITH_SYSTEM_GTEST "require and build with system gtest and gmock" OFF)
766766
if(WITH_SYSTEM_GTEST)
767-
find_package(GTest REQUIRED)
767+
find_package(GTest 1.13.0 REQUIRED)
768768
find_package(GMock REQUIRED)
769769
else()
770770
set(INSTALL_GTEST OFF CACHE BOOL "" FORCE)

src/googletest

Submodule googletest updated 282 files

src/test/neorados/common_tests.h

Lines changed: 3 additions & 6 deletions
Original file line numberDiff line numberDiff line change
@@ -396,18 +396,15 @@ class NeoRadosECTest : public NeoRadosTestBase {
396396
"test_suite_name must not be empty"); \
397397
static_assert(sizeof(GTEST_STRINGIFY_(test_name)) > 1, \
398398
"test_name must not be empty"); \
399-
class GTEST_TEST_CLASS_NAME_(test_suite_name, test_name) : public fixture { \
399+
class GTEST_TEST_CLASS_NAME_(test_suite_name, test_name) \
400+
: public fixture, private ::testing::internal::GTestNonCopyable { \
400401
public: \
401402
GTEST_TEST_CLASS_NAME_(test_suite_name, test_name)() = default; \
402403
~GTEST_TEST_CLASS_NAME_(test_suite_name, test_name)() override = default; \
403-
GTEST_DISALLOW_COPY_AND_ASSIGN_(GTEST_TEST_CLASS_NAME_(test_suite_name, \
404-
test_name)); \
405-
GTEST_DISALLOW_MOVE_AND_ASSIGN_(GTEST_TEST_CLASS_NAME_(test_suite_name, \
406-
test_name)); \
407404
\
408405
private: \
409406
boost::asio::awaitable<void> CoTestBody() override; \
410-
static ::testing::TestInfo *const test_info_ GTEST_ATTRIBUTE_UNUSED_; \
407+
[[maybe_unused]] static ::testing::TestInfo *const test_info_; \
411408
}; \
412409
\
413410
::testing::TestInfo *const GTEST_TEST_CLASS_NAME_(test_suite_name, \

0 commit comments

Comments
 (0)