Merge pull request ceph#61901 from cbodley/wip-69936

cbodley · web-flow · commit 7307a3def7e1 · 2025-02-28T09:35:31.000-05:00
rgw/cksum: GetObject omits checksum headers for Range requests

Reviewed-by: Matt Benjamin &lt;mbenjamin@redhat.com&gt;
diff --git a/src/rgw/rgw_rest_s3.cc b/src/rgw/rgw_rest_s3.cc
@@ -501,7 +501,10 @@ int RGWGetObj_ObjStore_S3::send_response_data(bufferlist& bl, off_t bl_ofs,
       }
     }
 
-    if (checksum_mode) {
+    // omit the stored full-object checksum headers if a Range is requested
+    // TODO: detect when a Range coincides with a single part of a multipart
+    // upload, and return its part checksum?
+    if (checksum_mode && !range_str) {
       if (auto i = attrs.find(RGW_ATTR_CKSUM); i != attrs.end()) {
 	try {
 	  rgw::cksum::Cksum cksum;

Original file line number	Diff line number	Diff line change
`@@ -501,7 +501,10 @@ int RGWGetObj_ObjStore_S3::send_response_data(bufferlist& bl, off_t bl_ofs,`
`501`	`501`	`}`
`502`	`502`	`}`
`503`	`503`
`504`		`- if (checksum_mode) {`
	`504`	`+ // omit the stored full-object checksum headers if a Range is requested`
	`505`	`+ // TODO: detect when a Range coincides with a single part of a multipart`
	`506`	`+ // upload, and return its part checksum?`
	`507`	`+ if (checksum_mode && !range_str) {`
`505`	`508`	`if (auto i = attrs.find(RGW_ATTR_CKSUM); i != attrs.end()) {`
`506`	`509`	`try {`
`507`	`510`	`rgw::cksum::Cksum cksum;`