rgw: metadata and data sync fairness notifications to retry upon any error case

This is a complementary fix to the earlier one described at ceph#62156.
When the sync shard notification fails due to any failures including timeout,
this change keeps the loop going for both metadata and data sync.

Fixes https://tracker.ceph.com/issues/70270

Signed-off-by: Oguzhan Ozmen <[email protected]>

Author: BBoozmen

src/rgw/driver/rados/rgw_data_sync.cc

@@ -2404,8 +2404,7 @@ class RGWDataSyncShardNotifyCR : public RGWCoroutine {
         set_status("sync lock notification");
         yield call(sync_env->bid_manager->notify_cr());
         if (retcode < 0) {
-          tn->log(5, SSTR("ERROR: failed to notify bidding information" << retcode));
-          return set_cr_error(retcode);
+          tn->log(5, SSTR("ERROR: failed to notify bidding information retcode=" << retcode));
         }
 
         set_status("sleeping");

src/rgw/driver/rados/rgw_sync.cc

@@ -1996,8 +1996,7 @@ class RGWMetaSyncShardNotifyCR : public RGWCoroutine {
         set_status("sync lock notification");
         yield call(sync_env->bid_manager->notify_cr());
         if (retcode < 0) {
-          tn->log(5, SSTR("ERROR: failed to notify bidding information" << retcode));
-          return set_cr_error(retcode);
+          tn->log(5, SSTR("ERROR: failed to notify bidding information retcode=" << retcode));
         }
 
         set_status("sleeping");