Merge pull request ceph#62185 from ronen-fr/wip-rf-more8-keys

kernel/KernelDevice: replace obsolete get_tracked_conf_keys()

Reviewed-by: Matt Vandermeulen <[email protected]>
Reviewed-by: Radoslaw Zarzynski <[email protected]>

Author: ronen-fr

src/blk/kernel/KernelDevice.cc

@@ -52,6 +52,7 @@ using std::list;
 using std::map;
 using std::string;
 using std::vector;
+using namespace std::literals;
 
 using ceph::bufferlist;
 using ceph::bufferptr;
@@ -1562,14 +1563,13 @@ int KernelDevice::invalidate_cache(uint64_t off, uint64_t len)
   return r;
 }
 
-const char** KernelDevice::get_tracked_conf_keys() const
+std::vector<std::string> KernelDevice::get_tracked_keys()
+    const noexcept
 {
-  static const char* KEYS[] = {
-    "bdev_async_discard_threads",
-    "bdev_enable_discard",
-    NULL
+  return {
+    "bdev_async_discard_threads"s,
+    "bdev_enable_discard"s
   };
-  return KEYS;
 }
 
 void KernelDevice::handle_conf_change(const ConfigProxy& conf,

src/blk/kernel/KernelDevice.h

@@ -166,7 +166,7 @@ class KernelDevice : public BlockDevice,
   void close() override;
 
   // config observer bits
-  const char** get_tracked_conf_keys() const override;
+  std::vector<std::string> get_tracked_keys() const noexcept override;
   void handle_conf_change(const ConfigProxy& conf,
                           const std::set <std::string> &changed) override;
 };