common: take string_view for strict_tobool

Signed-off-by: Patrick Donnelly <[email protected]>

Author: batrick

src/common/strtol.cc

@@ -22,13 +22,16 @@
 #include <strings.h>
 #include <string_view>
 
+#include <boost/algorithm/string/predicate.hpp>
+
 using std::ostringstream;
+using namespace std::literals::string_view_literals;
 
-bool strict_strtob(const char* str, std::string *err)
+bool strict_strtob(std::string_view str, std::string *err)
 {
-  if (strcasecmp(str, "false") == 0) {
+  if (boost::iequals(str, "false"sv)) {
     return false;
-  } else if (strcasecmp(str, "true") == 0) {
+  } else if (boost::iequals(str, "true"sv)) {
     return true;
   } else {
     int b = strict_strtol(str, 10, err);

src/common/strtol.h

@@ -69,7 +69,7 @@ auto consume(std::string_view& s, int base = 10)
 }
 } // namespace ceph
 
-bool strict_strtob(const char* str, std::string *err);
+bool strict_strtob(std::string_view str, std::string *err);
 
 long long strict_strtoll(std::string_view str, int base, std::string *err);