os/bluestore: Improve dout when bdev label cannot be decoded

aclamk · aclamk · commit 8c28695cde06 · 2025-01-21T17:12:01.000Z
Remove unuseful message about decoding failure.
Add location of bdev label that fails.

Signed-off-by: Adam Kupczyk &lt;akupczyk@ibm.com&gt;
diff --git a/src/os/bluestore/BlueStore.cc b/src/os/bluestore/BlueStore.cc
@@ -6684,10 +6684,8 @@ int BlueStore::_read_bdev_label(
     decode(expected_crc, p);
   }
   catch (ceph::buffer::error& e) {
-    derr << __func__ << " unable to decode label " << path.c_str()
-         << " at offset " << p.get_off()
-	 << ": " << e.what()
-	 << dendl;
+    derr << __func__ << " " << path.c_str() << " data at " << std::hex << disk_position
+      << std::dec << ", " << "unable to decode label " << dendl;
     return -ENOENT;
   }
   if (crc != expected_crc) {

Original file line number	Diff line number	Diff line change
`@@ -6684,10 +6684,8 @@ int BlueStore::_read_bdev_label(`
`6684`	`6684`	`decode(expected_crc, p);`
`6685`	`6685`	`}`
`6686`	`6686`	`catch (ceph::buffer::error& e) {`
`6687`		`- derr << __func__ << " unable to decode label " << path.c_str()`
`6688`		`- << " at offset " << p.get_off()`
`6689`		`- << ": " << e.what()`
`6690`		`- << dendl;`
	`6687`	`+ derr << __func__ << " " << path.c_str() << " data at " << std::hex << disk_position`
	`6688`	`+ << std::dec << ", " << "unable to decode label " << dendl;`
`6691`	`6689`	`return -ENOENT;`
`6692`	`6690`	`}`
`6693`	`6691`	`if (crc != expected_crc) {`