Merge pull request ceph#58292 from neesingh-rh/wip-vol-method-name-change

mgr/vol : shortening the name of helper method

Reviewed-by: Venky Shankar <[email protected]>
Reviewed-by: Rishabh Dave <[email protected]>

Author: vshankar

src/pybind/mgr/volumes/fs/operations/versions/metadata_manager.py

@@ -172,7 +172,7 @@ def list_all_options_from_section(self, section):
                 metadata_dict[option] = self.config.get(section,option)
         return metadata_dict
 
-    def list_all_keys_with_specified_values_from_section(self, section, value):
+    def filter_keys(self, section, value):
         keys = []
         if self.config.has_section(section):
             options = self.config.options(section)

src/pybind/mgr/volumes/fs/operations/versions/subvolume_v1.py

@@ -758,7 +758,7 @@ def get_pending_clones(self, snapname):
 
         try:
             if self.has_pending_clones(snapname):
-                pending_track_id_list = self.metadata_mgr.list_all_keys_with_specified_values_from_section('clone snaps', snapname)
+                pending_track_id_list = self.metadata_mgr.filter_keys('clone snaps', snapname)
             else:
                 return pending_clones_info
         except MetadataMgrException as me:
@@ -780,9 +780,9 @@ def get_pending_clones(self, snapname):
                     raise VolumeException(-e.args[0], e.args[1])
                 else:
                     try:
-                        # If clone is completed between 'list_all_keys_with_specified_values_from_section'
-                        # and readlink(track_id_path) call then readlink will fail with error ENOENT (2)
-                        # Hence we double check whether track_id is exist in .meta file or not.
+                        # If clone is completed between 'filter_keys' and readlink(track_id_path) call
+                        # then readlink will fail with error ENOENT (2). Hence we double check whether
+                        # track_id exists in .meta file or not.
                         # Edge case scenario.
                         # If track_id for clone exist but path /volumes/_index/clone/{track_id} not found
                         # then clone is orphan.