Skip to content

Commit b5e7008

Browse files
committed
ceph-volume: address mypy errors in disk.py
typical error: ``` ceph_volume/util/disk.py:1374: error: Incompatible types in assignment (expression has type "Optional[str]", variable has type "str") [assignment] ``` This commits addresses it. Signed-off-by: Guillaume Abrioux <[email protected]>
1 parent dd2a150 commit b5e7008

File tree

1 file changed

+3
-3
lines changed
  • src/ceph-volume/ceph_volume/util

1 file changed

+3
-3
lines changed

src/ceph-volume/ceph_volume/util/disk.py

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -1370,8 +1370,8 @@ def slashed_path(self) -> str:
13701370
"""
13711371
result: str = self.path
13721372
if self.is_lvm:
1373-
vg: str = self.environment.get('DM_VG_NAME')
1374-
lv: str = self.environment.get('DM_LV_NAME')
1373+
vg: str = self.environment.get('DM_VG_NAME', '')
1374+
lv: str = self.environment.get('DM_LV_NAME', '')
13751375
result = f'/dev/{vg}/{lv}'
13761376
return result
13771377

@@ -1385,6 +1385,6 @@ def dashed_path(self) -> str:
13851385
"""
13861386
result: str = self.path
13871387
if self.is_lvm:
1388-
name: str = self.environment.get('DM_NAME')
1388+
name: str = self.environment.get('DM_NAME', '')
13891389
result = f'/dev/mapper/{name}'
13901390
return result

0 commit comments

Comments
 (0)