mgr/cephadm: initialize results list in deploy_and_remove_all

adk3798 · adk3798 · commit b7ab1bc7362e · 2025-06-24T15:33:18.000-04:00
If we don't actually deploy anything it ends up referencing
an unassigned variable

Signed-off-by: Adam King &lt;adking@redhat.com&gt;

Resolves: rhbz#2374651
diff --git a/src/pybind/mgr/cephadm/serve.py b/src/pybind/mgr/cephadm/serve.py
@@ -737,6 +737,7 @@ async def _deploy_and_remove_all(
             + [d.name() for d in all_conflicting_daemons]
             + [d.name() for d in all_daemons_to_remove]
         )
+        results: List[Tuple[bool, Set[str], List[str]]] = []
         for tier in sorted(all_daemons_to_deploy.keys()):
             all_daemons_in_tier_to_deploy = all_daemons_to_deploy[tier]
             deploy_names = [d.name() for d in all_daemons_in_tier_to_deploy]

Original file line number	Diff line number	Diff line change
`@@ -737,6 +737,7 @@ async def _deploy_and_remove_all(`
`737`	`737`	`+ [d.name() for d in all_conflicting_daemons]`
`738`	`738`	`+ [d.name() for d in all_daemons_to_remove]`
`739`	`739`	`)`
	`740`	`+ results: List[Tuple[bool, Set[str], List[str]]] = []`
`740`	`741`	`for tier in sorted(all_daemons_to_deploy.keys()):`
`741`	`742`	`all_daemons_in_tier_to_deploy = all_daemons_to_deploy[tier]`
`742`	`743`	`deploy_names = [d.name() for d in all_daemons_in_tier_to_deploy]`