Skip to content

Commit c5270aa

Browse files
committed
Merge PR ceph#61979 into main
* refs/pull/61979/head: script/ceph-backport: remove upstream remote inferencing Reviewed-by: Guillaume Abrioux <[email protected]>
2 parents c3c9e6d + b340461 commit c5270aa

File tree

1 file changed

+6
-23
lines changed

1 file changed

+6
-23
lines changed

src/script/ceph-backport.sh

Lines changed: 6 additions & 23 deletions
Original file line numberDiff line numberDiff line change
@@ -20,6 +20,8 @@ set -e
2020
# ceph-backport.sh --troubleshooting | less
2121
#
2222

23+
CEPH_UPSTREAM=https://github.com/ceph/ceph.git
24+
2325
full_path="$0"
2426

2527
SCRIPT_VERSION="16.0.0.6848"
@@ -258,7 +260,7 @@ function cherry_pick_phase {
258260
fi
259261

260262
set -x
261-
git fetch "$upstream_remote" "refs/heads/${milestone}"
263+
git fetch "$CEPH_UPSTREAM" "refs/heads/${milestone}"
262264

263265
if git show-ref --verify --quiet "refs/heads/$local_branch" ; then
264266
if [ "$FORCE" ] ; then
@@ -292,7 +294,7 @@ function cherry_pick_phase {
292294
git checkout -b "$local_branch" FETCH_HEAD
293295
fi
294296

295-
git fetch "$upstream_remote" "$merge_commit_sha"
297+
git fetch "$CEPH_UPSTREAM" "$merge_commit_sha"
296298

297299
set +x
298300
maybe_restore_set_x
@@ -554,10 +556,6 @@ function init_redmine_key {
554556
fi
555557
}
556558

557-
function init_upstream_remote {
558-
upstream_remote="${upstream_remote:-$(maybe_deduce_remote upstream)}"
559-
}
560-
561559
function interactive_setup_routine {
562560
local default_val
563561
local original_github_token
@@ -637,15 +635,13 @@ function interactive_setup_routine {
637635
echo "---------------------------------------------------------------------"
638636
echo "Searching \"git remote -v\" for remote repos"
639637
echo
640-
init_upstream_remote
641638
init_fork_remote
642639
vet_remotes
643-
echo "Upstream remote is \"$upstream_remote\""
640+
echo "Upstream remote is \"$CEPH_UPSTREAM\""
644641
echo "Fork remote is \"$fork_remote\""
645642
[ "$setup_ok" ] || abort_due_to_setup_problem
646643
[ "$github_token" ] || assert_fail "github_token not set, even after completing Steps 1-3 of interactive setup"
647644
[ "$github_user" ] || assert_fail "github_user not set, even after completing Steps 1-3 of interactive setup"
648-
[ "$upstream_remote" ] || assert_fail "upstream_remote not set, even after completing Steps 1-3 of interactive setup"
649645
[ "$fork_remote" ] || assert_fail "fork_remote not set, even after completing Steps 1-3 of interactive setup"
650646
echo
651647
echo "---------------------------------------------------------------------"
@@ -682,7 +678,6 @@ function interactive_setup_routine {
682678
fi
683679
[ "$github_token" ] || assert_fail "github_token not set, even after completing Steps 1-4 of interactive setup"
684680
[ "$github_user" ] || assert_fail "github_user not set, even after completing Steps 1-4 of interactive setup"
685-
[ "$upstream_remote" ] || assert_fail "upstream_remote not set, even after completing Steps 1-4 of interactive setup"
686681
[ "$fork_remote" ] || assert_fail "fork_remote not set, even after completing Steps 1-4 of interactive setup"
687682
[ "$redmine_key" ] || assert_fail "redmine_key not set, even after completing Steps 1-4 of interactive setup"
688683
[ "$redmine_user_id" ] || assert_fail "redmine_user_id not set, even after completing Steps 1-4 of interactive setup"
@@ -1267,13 +1262,6 @@ function vet_prs_for_milestone {
12671262
}
12681263

12691264
function vet_remotes {
1270-
if [ "$upstream_remote" ] ; then
1271-
verbose "Upstream remote is $upstream_remote"
1272-
else
1273-
error "Cannot auto-determine upstream remote"
1274-
"(Could not find any upstream remote in \"git remote -v\")"
1275-
false
1276-
fi
12771265
if [ "$fork_remote" ] ; then
12781266
verbose "Fork remote is $fork_remote"
12791267
else
@@ -1295,14 +1283,12 @@ function vet_setup {
12951283
local redmine_user_id_display
12961284
local github_endpoint_display
12971285
local github_user_display
1298-
local upstream_remote_display
12991286
local fork_remote_display
13001287
local redmine_key_display
13011288
local github_token_display
13021289
debug "Entering vet_setup with argument $argument"
13031290
if [ "$argument" = "--report" ] || [ "$argument" = "--normal-operation" ] ; then
13041291
[ "$github_token" ] && [ "$setup_ok" ] && set_github_user_from_github_token quiet
1305-
init_upstream_remote
13061292
[ "$github_token" ] && [ "$setup_ok" ] && init_fork_remote
13071293
vet_remotes
13081294
[ "$redmine_key" ] && set_redmine_user_from_redmine_key
@@ -1329,15 +1315,13 @@ function vet_setup {
13291315
redmine_user_id_display="${redmine_user_id:-$not_set}"
13301316
github_endpoint_display="${github_endpoint:-$not_set}"
13311317
github_user_display="${github_user:-$not_set}"
1332-
upstream_remote_display="${upstream_remote:-$not_set}"
13331318
fork_remote_display="${fork_remote:-$not_set}"
13341319
test "$redmine_endpoint" || failed_mandatory_var_check redmine_endpoint "not set"
13351320
test "$redmine_user_id" || failed_mandatory_var_check redmine_user_id "could not be determined"
13361321
test "$redmine_key" || failed_mandatory_var_check redmine_key "not set"
13371322
test "$github_endpoint" || failed_mandatory_var_check github_endpoint "not set"
13381323
test "$github_user" || failed_mandatory_var_check github_user "could not be determined"
13391324
test "$github_token" || failed_mandatory_var_check github_token "not set"
1340-
test "$upstream_remote" || failed_mandatory_var_check upstream_remote "could not be determined"
13411325
test "$fork_remote" || failed_mandatory_var_check fork_remote "could not be determined"
13421326
if [ "$argument" = "--report" ] || [ "$argument" == "--interactive" ] ; then
13431327
read -r -d '' setup_summary <<EOM || true > /dev/null 2>&1
@@ -1347,7 +1331,7 @@ redmine_key $redmine_key_display
13471331
github_endpoint $github_endpoint
13481332
github_user $github_user_display
13491333
github_token $github_token_display
1350-
upstream_remote $upstream_remote_display
1334+
upstream_remote $CEPH_UPSTREAM
13511335
fork_remote $fork_remote_display
13521336
EOM
13531337
log bare
@@ -1365,7 +1349,6 @@ EOM
13651349
verbose "github_endpoint $github_endpoint_display"
13661350
verbose "github_user $github_user_display"
13671351
verbose "github_token $github_token_display"
1368-
verbose "upstream_remote $upstream_remote_display"
13691352
verbose "fork_remote $fork_remote_display"
13701353
fi
13711354
if [ "$argument" = "--report" ] || [ "$argument" = "--interactive" ] ; then

0 commit comments

Comments
 (0)