crimson/os/seastore: rename type remap_entry to remap_entry_t

Signed-off-by: Zhang Song <[email protected]>
(cherry picked from commit 14afe98)

Author: zhscn

src/crimson/os/seastore/lba_manager.h

@@ -118,10 +118,10 @@ class LBAManager {
     Transaction &t,
     laddr_t addr) = 0;
 
-  struct remap_entry {
+  struct remap_entry_t {
     extent_len_t offset;
     extent_len_t len;
-    remap_entry(extent_len_t _offset, extent_len_t _len) {
+    remap_entry_t(extent_len_t _offset, extent_len_t _len) {
       offset = _offset;
       len = _len;
     }
@@ -142,7 +142,7 @@ class LBAManager {
   virtual remap_ret remap_mappings(
     Transaction &t,
     LBAMappingRef orig_mapping,
-    std::vector<remap_entry> remaps,
+    std::vector<remap_entry_t> remaps,
     std::vector<LogicalChildNodeRef> extents  // Required if and only
 						 // if pin isn't indirect
     ) = 0;

src/crimson/os/seastore/lba_manager/btree/btree_lba_manager.h

@@ -233,7 +233,7 @@ class BtreeLBAManager : public LBAManager {
   remap_ret remap_mappings(
     Transaction &t,
     LBAMappingRef orig_mapping,
-    std::vector<remap_entry> remaps,
+    std::vector<remap_entry_t> remaps,
     std::vector<LogicalChildNodeRef> extents) final {
     LOG_PREFIX(BtreeLBAManager::remap_mappings);
     assert((orig_mapping->is_indirect())

src/crimson/os/seastore/object_data_handler.cc

@@ -131,24 +131,24 @@ struct extent_to_remap_t {
     return type == type_t::OVERWRITE;
   }
 
-  using remap_entry = TransactionManager::remap_entry;
-  remap_entry create_remap_entry() {
+  using remap_entry_t = TransactionManager::remap_entry_t;
+  remap_entry_t create_remap_entry() {
     assert(is_remap1());
-    return remap_entry(
+    return remap_entry_t(
       new_offset,
       new_len);
   }
 
-  remap_entry create_left_remap_entry() {
+  remap_entry_t create_left_remap_entry() {
     assert(is_remap2());
-    return remap_entry(
+    return remap_entry_t(
       0,
       new_offset);
   }
 
-  remap_entry create_right_remap_entry() {
+  remap_entry_t create_right_remap_entry() {
     assert(is_remap2());
-    return remap_entry(
+    return remap_entry_t(
       new_offset + new_len,
       pin->get_length() - new_offset - new_len);
   }

src/crimson/os/seastore/transaction_manager.h

@@ -486,14 +486,14 @@ class TransactionManager : public ExtentCallbackInterface {
    * Remap original extent to new extents.
    * Return the pins of new extent.
    */
-  using remap_entry = LBAManager::remap_entry;
+  using remap_entry_t = LBAManager::remap_entry_t;
   using remap_pin_iertr = base_iertr;
   using remap_pin_ret = remap_pin_iertr::future<std::vector<LBAMappingRef>>;
   template <typename T, std::size_t N>
   remap_pin_ret remap_pin(
     Transaction &t,
     LBAMappingRef &&pin,
-    std::array<remap_entry, N> remaps) {
+    std::array<remap_entry_t, N> remaps) {
     static_assert(std::is_base_of_v<LogicalChildNode, T>);
     // data extents don't need maybe_init yet, currently,
     static_assert(is_data_type(T::TYPE));
@@ -502,7 +502,7 @@ class TransactionManager : public ExtentCallbackInterface {
 
 #ifndef NDEBUG
     std::sort(remaps.begin(), remaps.end(),
-      [](remap_entry x, remap_entry y) {
+      [](remap_entry_t x, remap_entry_t y) {
         return x.offset < y.offset;
     });
     auto original_len = pin->get_length();
@@ -632,7 +632,7 @@ class TransactionManager : public ExtentCallbackInterface {
 	return lba_manager->remap_mappings(
 	  t,
 	  std::move(pin),
-	  std::vector<remap_entry>(remaps.begin(), remaps.end()),
+	  std::vector<remap_entry_t>(remaps.begin(), remaps.end()),
 	  std::move(extents)
 	).si_then([FNAME, &t](auto ret) {
 	  SUBDEBUGT(seastore_tm, "remapped {} pins",

src/test/crimson/seastore/test_object_data_handler.cc

@@ -242,7 +242,7 @@ struct object_data_handler_test_t:
     return ret;
   }
 
-  using remap_entry = TransactionManager::remap_entry;
+  using remap_entry_t = TransactionManager::remap_entry_t;
   LBAMappingRef remap_pin(
     Transaction &t,
     LBAMappingRef &&opin,
@@ -251,7 +251,7 @@ struct object_data_handler_test_t:
     auto pin = with_trans_intr(t, [&](auto& trans) {
       return tm->remap_pin<ObjectDataBlock>(
         trans, std::move(opin), std::array{
-          remap_entry(new_offset, new_len)}
+          remap_entry_t(new_offset, new_len)}
       ).si_then([](auto ret) {
         return std::move(ret[0]);
       });

src/test/crimson/seastore/test_transaction_manager.cc

@@ -1097,7 +1097,7 @@ struct transaction_manager_test_t :
     });
   }
 
-  using remap_entry = TransactionManager::remap_entry;
+  using remap_entry_t = TransactionManager::remap_entry_t;
   LBAMappingRef remap_pin(
     test_transaction_t &t,
     LBAMappingRef &&opin,
@@ -1114,7 +1114,7 @@ struct transaction_manager_test_t :
     auto pin = with_trans_intr(*(t.t), [&](auto& trans) {
       return tm->remap_pin<TestBlock>(
         trans, std::move(opin), std::array{
-          remap_entry(new_offset, new_len)}
+          remap_entry_t(new_offset, new_len)}
       ).si_then([](auto ret) {
         return std::move(ret[0]);
       });
@@ -1166,10 +1166,10 @@ struct transaction_manager_test_t :
         t,
         std::move(opin),
         std::array{
-          remap_entry(
+          remap_entry_t(
             0,
             new_offset),
-          remap_entry(
+          remap_entry_t(
             new_offset + new_len,
             o_len - new_offset - new_len)
         }
@@ -1205,7 +1205,7 @@ struct transaction_manager_test_t :
         t,
         std::move(opin),
         std::array{
-          remap_entry(
+          remap_entry_t(
             new_offset + new_len,
             o_len - new_offset - new_len)
         }
@@ -1236,7 +1236,7 @@ struct transaction_manager_test_t :
         t,
         std::move(opin),
         std::array{
-          remap_entry(
+          remap_entry_t(
             0,
             new_offset)
         }