Skip to content

Commit e56665c

Browse files
committed
Merge PR ceph#54396 into main
* refs/pull/54396/head: PendingReleaseNote: add note for pause_purging and pause_cloninig doc/cephfs: add note for config option pause_purging and pause_cloning qa/cephfs: add tests for mgr/vol config pause_cloning qa/cephfs: extend wait for trash empty qa/cephfs: add tests for config option pause_purging qa/cephfs: don't strip any whitespace for get_shell_stdout mgr/vol: add pause/resume mechanism for async jobs Reviewed-by: Venky Shankar <[email protected]>
2 parents 5fffe86 + 03b90d5 commit e56665c

File tree

8 files changed

+488
-14
lines changed

8 files changed

+488
-14
lines changed

PendingReleaseNotes

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -48,6 +48,13 @@
4848
This can be necessary in cases where we wish to prevent the manager from being
4949
flooded by module commands when Ceph services are down or degraded.
5050

51+
* CephFS: It is now possible to pause the threads that asynchronously purge
52+
the deleted subvolumes by using the config option
53+
"mgr/volumes/pause_purging".
54+
* CephFS: It is now possible to pause the threads that asynchronously clone
55+
the subvolume snapshots by using the config option
56+
"mgr/volumes/pause_cloning".
57+
5158
* CephFS: Modifying the setting "max_mds" when a cluster is
5259
unhealthy now requires users to pass the confirmation flag
5360
(--yes-i-really-mean-it). This has been added as a precaution to tell the

doc/cephfs/fs-volumes.rst

Lines changed: 26 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -959,6 +959,32 @@ Configure the maximum number of concurrent clone operations. The default is 4:
959959

960960
ceph config set mgr mgr/volumes/max_concurrent_clones <value>
961961

962+
Pause the threads that asynchronously purge trashed subvolumes. This option is
963+
useful during cluster recovery scenarios:
964+
965+
.. prompt:: bash #
966+
967+
ceph config set mgr/volumes/pause_purging true
968+
969+
To resume purging threads:
970+
971+
.. prompt:: bash #
972+
973+
ceph config set mgr/volumes/pause_purging false
974+
975+
Pause the threads that asynchronously clone subvolume snapshots. This option is
976+
useful during cluster recovery scenarios:
977+
978+
.. prompt:: bash #
979+
980+
ceph config set mgr/volumes/pause_cloning true
981+
982+
To resume cloning threads:
983+
984+
.. prompt:: bash #
985+
986+
ceph config set mgr/volumes/pause_cloning false
987+
962988
Configure the ``snapshot_clone_no_wait`` option:
963989

964990
The ``snapshot_clone_no_wait`` config option is used to reject clone-creation

doc/cephfs/troubleshooting.rst

Lines changed: 25 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -134,6 +134,31 @@ things to do:
134134
be changed in such circumstances, run the command to change ``max_mds`` with
135135
the confirmation flag (``--yes-i-really-mean-it``)
136136

137+
* **Turn off async purge threads** The volumes plugin spawns threads for
138+
asynchronously purging trashed/deleted subvolumes. To help troubleshooting or
139+
recovery effort, these purge threads can be disabled using:
140+
141+
.. code:: bash
142+
143+
ceph config set mgr mgr/volumes/pause_purging true
144+
145+
To resume purging run::
146+
147+
ceph config set mgr mgr/volumes/pause_purging false
148+
149+
* **Turn off async cloner threads** The volumes plugin spawns threads for
150+
asynchronously cloning subvolume snapshots. To help troubleshooting or
151+
recovery effort, these cloner threads can be disabled using:
152+
153+
.. code:: bash
154+
155+
ceph config set mgr mgr/volumes/pause_cloning true
156+
157+
To resume cloning run::
158+
159+
ceph config set mgr mgr/volumes/pause_cloning false
160+
161+
137162
138163
Expediting MDS journal trim
139164
===========================
Lines changed: 6 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -0,0 +1,6 @@
1+
tasks:
2+
- cephfs_test_runner:
3+
fail_on_skip: false
4+
modules:
5+
- tasks.cephfs.test_volumes.TestPausePurging
6+
- tasks.cephfs.test_volumes.TestPauseCloning

qa/tasks/cephfs/mount.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -785,7 +785,7 @@ def run_shell(self, args, **kwargs):
785785

786786
def get_shell_stdout(self, args, timeout=300, **kwargs):
787787
return self.run_shell(args=args, timeout=timeout, **kwargs).stdout.\
788-
getvalue().strip()
788+
getvalue()
789789

790790
def run_shell_payload(self, payload, wait=True, timeout=900, **kwargs):
791791
kwargs.setdefault('cwd', self.mountpoint)

0 commit comments

Comments
 (0)