Skip to content

Commit ecd2496

Browse files
committed
qa: Disable referent inodes for a few test_strays tests
It's disabled for following tests test_hardlink_reintegration test_mv_hardlink_cleanup The stray perf count numbers validation in above tests don't match with referent inodes enabled because referent inodes becomes a stray whenever hardlink is deleted or stray is reintegrated, so disable referent inodes. The same test for referent inodes is added at qa/tasks/cephfs/test_referent.py adjusting the perf counters for referent inodes. Fixes: https://tracker.ceph.com/issues/69339 Signed-off-by: Kotresh HR <[email protected]>
1 parent f27a47a commit ecd2496

File tree

1 file changed

+15
-0
lines changed

1 file changed

+15
-0
lines changed

qa/tasks/cephfs/test_strays.py

Lines changed: 15 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -380,7 +380,15 @@ def test_hardlink_reintegration(self):
380380
in reintegration of inode into the previously-remote dentry,
381381
rather than lingering as a stray indefinitely.
382382
"""
383+
384+
# stray perf count numbers in the test don't match when referent inode feature
385+
# is enabled because referent inodes becomes a stray whenever hardlink is
386+
# deleted or stray is reintegrated, so disable referent inodes here. The
387+
# same test for referent inodes is added at qa/tasks/cephfs/test_referent.py
388+
self.fs.set_allow_referent_inodes(False)
389+
383390
# Write some bytes to file_a
391+
384392
size_mb = 8
385393
self.mount_a.run_shell(["mkdir", "dir_1"])
386394
self.mount_a.write_n_mb("dir_1/file_a", size_mb)
@@ -542,6 +550,13 @@ def test_mv_hardlink_cleanup(self):
542550
then we make a stray for B which is then reintegrated
543551
into one of his hardlinks.
544552
"""
553+
554+
# stray perf count numbers in the test don't match when referent inode feature
555+
# is enabled because referent inodes becomes a stray whenever hardlink is
556+
# deleted or stray is reintegrated, so disable referent inodes here. The
557+
# same test for referent inodes is added at qa/tasks/cephfs/test_referent.py
558+
self.fs.set_allow_referent_inodes(False)
559+
545560
# Create file_a, file_b, and a hardlink to file_b
546561
size_mb = 8
547562
self.mount_a.write_n_mb("file_a", size_mb)

0 commit comments

Comments
 (0)