Skip to content

Commit f590661

Browse files
committed
mgr/dashboard:fixed issue with notification icon
Fixes:https://tracker.ceph.com/issues/70253 Signed-off-by: Ankit Kumar <[email protected]>
1 parent 96730b2 commit f590661

File tree

4 files changed

+9
-8
lines changed

4 files changed

+9
-8
lines changed

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.html

Lines changed: 3 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -33,8 +33,9 @@
3333
<cds-header-navigation>
3434
<cd-language-selector class="d-flex"></cd-language-selector>
3535
</cds-header-navigation>
36-
<div class="cds--btn cds--btn--icon-only cds--header__action">
37-
<cd-notifications (click)="toggleRightSidebar()"></cd-notifications>
36+
<div class="cds--btn cds--btn--icon-only cds--header__action"
37+
(click)="toggleSidebar()">
38+
<cd-notifications></cd-notifications>
3839
</div>
3940
<div class="cds--btn cds--btn--icon-only cds--header__action">
4041
<cd-dashboard-help></cd-dashboard-help>

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/navigation/navigation.component.ts

Lines changed: 5 additions & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -14,6 +14,7 @@ import {
1414
FeatureTogglesMap$,
1515
FeatureTogglesService
1616
} from '~/app/shared/services/feature-toggles.service';
17+
import { NotificationService } from '~/app/shared/services/notification.service';
1718
import { PrometheusAlertService } from '~/app/shared/services/prometheus-alert.service';
1819
import { SummaryService } from '~/app/shared/services/summary.service';
1920

@@ -49,6 +50,7 @@ export class NavigationComponent implements OnInit, OnDestroy {
4950
currentClusterName: string;
5051

5152
constructor(
53+
public notificationService: NotificationService,
5254
private authStorageService: AuthStorageService,
5355
private multiClusterService: MultiClusterService,
5456
private router: Router,
@@ -189,7 +191,9 @@ export class NavigationComponent implements OnInit, OnDestroy {
189191
}
190192
);
191193
}
192-
194+
toggleSidebar() {
195+
this.notificationService.toggleSidebar();
196+
}
193197
trackByFn(item: any) {
194198
return item;
195199
}

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.html

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1,7 +1,7 @@
11
<a i18n-title
22
title="Tasks and Notifications"
33
[ngClass]="{ 'running': hasRunningTasks }"
4-
(click)="toggleSidebar()">
4+
>
55
<svg cdsIcon="notification"
66
size="20"
77
title="notification"></svg>

src/pybind/mgr/dashboard/frontend/src/app/core/navigation/notifications/notifications.component.ts

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -40,8 +40,4 @@ export class NotificationsComponent implements OnInit, OnDestroy {
4040
ngOnDestroy(): void {
4141
this.subs.unsubscribe();
4242
}
43-
44-
toggleSidebar() {
45-
this.notificationService.toggleSidebar();
46-
}
4743
}

0 commit comments

Comments
 (0)