Skip to content

Commit f646562

Browse files
authored
Merge pull request ceph#61396 from ShwetaBhosale1/fix_issue_69541_after_nvmeof_deployment_10008_port_not_opened
mgr/cephadm: After deploying nvmeof gateway group, the prometheus port 10008/tcp is not opened Reviewed-by: Adam King <[email protected]>
2 parents b7ffe0a + ac4c37d commit f646562

File tree

2 files changed

+3
-3
lines changed

2 files changed

+3
-3
lines changed

src/pybind/mgr/cephadm/tests/test_services.py

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -481,11 +481,11 @@ def test_nvmeof_config(self, _get_name, _run_cephadm, cephadm_module: CephadmOrc
481481
"image": "",
482482
"deploy_arguments": [],
483483
"params": {
484-
"tcp_ports": [5500, 4420, 8009]
484+
"tcp_ports": [5500, 4420, 8009, 10008]
485485
},
486486
"meta": {
487487
"service_name": "nvmeof.testpool",
488-
"ports": [5500, 4420, 8009],
488+
"ports": [5500, 4420, 8009, 10008],
489489
"ip": None,
490490
"deployed_by": [],
491491
"rank": None,

src/python-common/ceph/deployment/service_spec.py

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -1553,7 +1553,7 @@ def __init__(self,
15531553
self.monitor_client_log_file_dir = monitor_client_log_file_dir
15541554

15551555
def get_port_start(self) -> List[int]:
1556-
return [self.port, 4420, self.discovery_port]
1556+
return [self.port, 4420, self.discovery_port, self.prometheus_port]
15571557

15581558
def validate(self) -> None:
15591559
# TODO: what other parameters should be validated as part of this function?

0 commit comments

Comments
 (0)