Skip to content

Commit f992060

Browse files
Merge pull request ceph#61072 from pecastro/doc_and_test_fixes
Doc and test fixes
2 parents 3f1f345 + 2b2ce78 commit f992060

File tree

3 files changed

+7
-7
lines changed

3 files changed

+7
-7
lines changed

src/pybind/mgr/dashboard/HACKING.rst

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -4,7 +4,7 @@ Ceph Dashboard Developer Documentation
44
Note: The content of this file has been moved into the Ceph Developer Guide.
55

66
If you're interested in helping with the development of the dashboard, please
7-
see ``/doc/dev/developer_guide/dash_devel.rst`` or the `online version
7+
see ``/doc/dev/developer_guide/dash-devel.rst`` or the `online version
88
<https://ceph.readthedocs.io/en/latest/dev/developer_guide/dash-devel/>`_ for
99
details on how to set up a development environment and other development-related
1010
topics.

src/test/pybind/test_ceph_argparse.py

Lines changed: 5 additions & 5 deletions
Original file line numberDiff line numberDiff line change
@@ -217,7 +217,7 @@ def test_debug(self):
217217
def test_pg_missing_args_output(self):
218218
ret, _, stderr = self._capture_output(['pg'], stderr=True)
219219
self.assertEqual({}, ret)
220-
self.assertRegexpMatches(stderr, re.compile('no valid command found.* closest matches'))
220+
self.assertRegex(stderr, re.compile('no valid command found.* closest matches'))
221221

222222
def test_pg_wrong_arg_output(self):
223223
ret, _, stderr = self._capture_output(['pg', 'map', 'bad-pgid'],
@@ -416,10 +416,10 @@ def test_incompat_rm_incompat(self):
416416

417417

418418
class TestFS(TestArgparse):
419-
419+
420420
def test_dump(self):
421421
self.check_0_or_1_natural_arg('fs', 'dump')
422-
422+
423423
def test_fs_new(self):
424424
self._assert_valid_command(['fs', 'new', 'default', 'metadata', 'data'])
425425

@@ -912,7 +912,7 @@ def test_blocklist(self):
912912
'1.2.3.4/567', '600.40'])
913913
self._assert_valid_command(['osd', 'blocklist', action,
914914
'1.2.3.4', '600.40'])
915-
915+
916916
self._assert_valid_command(['osd', 'blocklist', action,
917917
'v1:1.2.3.4', '600.40'])
918918
self._assert_valid_command(['osd', 'blocklist', action,
@@ -925,7 +925,7 @@ def test_blocklist(self):
925925
'v2:[2607:f298:4:2243::5522]:0/0', '600.40'])
926926
self._assert_valid_command(['osd', 'blocklist', action,
927927
'[2001:0db8::85a3:0000:8a2e:0370:7334]:0/0', '600.40'])
928-
928+
929929
self.assertEqual({}, validate_command(sigdict, ['osd', 'blocklist',
930930
action,
931931
'invalid',

src/tools/cephfs/top/cephfs-top

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -148,7 +148,7 @@ def wrap(s, sl):
148148
"""return a '+' suffixed wrapped string"""
149149
if len(s) < sl:
150150
return s
151-
return f'{s[0:sl-1]}+'
151+
return f'{s[0:sl - 1]}+'
152152

153153

154154
class FSTopBase(object):

0 commit comments

Comments
 (0)