Merge pull request ceph#61878 from linuxbox2/wip-cksum-badalg

rgw: cksum:  implement support for new CRC64NVME checksum algorithm and related fixes

Reviewed-by: Casey Bodley <[email protected]>

Author: cbodley

COPYING

@@ -224,3 +224,26 @@ License: GNU Affero General Public License, Version 3
 Files: src/common/*s390x*
 Copyright: 2024 IBM <[email protected]>
 License: Apache License, version 2.0
+
+Files: src/rgw/madler/*
+License:
+  Copyright (C) 2014-2025 Mark Adler
+
+  This software is provided 'as-is', without any express or implied warranty.
+  In no event will the authors be held liable for any damages arising from the
+  use of this software.
+
+  Permission is granted to anyone to use this software for any purpose,
+  including commercial applications, and to alter it and redistribute it
+  freely, subject to the following restrictions:
+
+  1. The origin of this software must not be misrepresented; you must not claim
+     that you wrote the original software. If you use this software in a
+     product, an acknowledgment in the product documentation would be
+     appreciated but is not required.
+  2. Altered source versions must be plainly marked as such, and must not be
+     misrepresented as being the original software.
+  3. This notice may not be removed or altered from any source distribution.
+
+  Mark Adler
+  [email protected]

src/crypto/isa-l/CMakeLists.txt

@@ -1,4 +1,6 @@
 # build isa-l_crypto from its makefile and expose as target ISAL::Crypto
+set(CEPH_HAVE_ISAL, TRUE)
+
 include(BuildISALCrypto)
 build_isal_crypto()
 

src/rgw/CMakeLists.txt

@@ -19,6 +19,11 @@ if(WITH_RADOSGW_ARROW_FLIGHT)
   message("-- arrow flight is installed")
 endif(WITH_RADOSGW_ARROW_FLIGHT)
 
+if(CEPH_HAVE_ISAL)
+  message("-- building RGW with ISA-L support")
+  add_definitions(-DSPDK_CONFIG_ISAL)
+endif()
+
 function(gperf_generate input output)
   add_custom_command(
     OUTPUT ${output}
@@ -51,6 +56,10 @@ set(librgw_common_srcs
   services/svc_user_rados.cc
   services/svc_zone.cc
   services/svc_zone_utils.cc
+  spdk/crc64.c
+  madler/crc64nvme.c
+  madler/crc32iso_hdlc.c
+  madler/crc32iscsi.c
   rgw_account.cc
   rgw_acl.cc
   rgw_acl_s3.cc
@@ -65,6 +74,7 @@ set(librgw_common_srcs
   rgw_bucket.cc
   rgw_bucket_layout.cc
   rgw_cache.cc
+  rgw_cksum.cc
   rgw_cksum_pipe.cc
   rgw_common.cc
   rgw_compression.cc

src/rgw/driver/rados/rgw_sal_rados.cc

@@ -3841,6 +3841,7 @@ int RadosMultipartUpload::init(const DoutPrefixProvider *dpp, optional_yield y,
     multipart_upload_info upload_info;
     upload_info.dest_placement = dest_placement;
     upload_info.cksum_type = cksum_type;
+    upload_info.cksum_flags = cksum_flags;
 
     if (obj_legal_hold) {
       upload_info.obj_legal_hold_exist = true;
@@ -4256,6 +4257,7 @@ int RadosMultipartUpload::get_info(const DoutPrefixProvider *dpp, optional_yield
     return -EIO;
   }
   cksum_type = upload_info.cksum_type;
+  cksum_flags = upload_info.cksum_flags;
   placement = upload_info.dest_placement;
   upload_information = upload_info;
   *rule = &placement;

src/rgw/madler/LICENSE

@@ -0,0 +1,20 @@
+  Copyright (C) 2014-2025 Mark Adler
+
+  This software is provided 'as-is', without any express or implied warranty.
+  In no event will the authors be held liable for any damages arising from the
+  use of this software.
+
+  Permission is granted to anyone to use this software for any purpose,
+  including commercial applications, and to alter it and redistribute it
+  freely, subject to the following restrictions:
+
+  1. The origin of this software must not be misrepresented; you must not claim
+     that you wrote the original software. If you use this software in a
+     product, an acknowledgment in the product documentation would be
+     appreciated but is not required.
+  2. Altered source versions must be plainly marked as such, and must not be
+     misrepresented as being the original software.
+  3. This notice may not be removed or altered from any source distribution.
+
+  Mark Adler
+  [email protected]

src/rgw/madler/crc32iscsi.c

@@ -0,0 +1,27 @@
+// The _bit, _byte, and _word routines return the CRC of the len
+// bytes at mem, applied to the previous CRC value, crc. If mem is
+// NULL, then the other arguments are ignored, and the initial CRC,
+// i.e. the CRC of zero bytes, is returned. Those routines will all
+// return the same result, differing only in speed and code
+// complexity. The _rem routine returns the CRC of the remaining
+// bits in the last byte, for when the number of bits in the
+// message is not a multiple of eight. The low bits bits of the low
+// byte of val are applied to crc. bits must be in 0..8.
+
+#include <stddef.h>
+#include <stdint.h>
+
+// Compute the CRC a bit at a time.
+uint32_t crc32iscsi_bit(uint32_t crc, void const *mem, size_t len);
+
+// Compute the CRC of the low bits bits in val.
+uint32_t crc32iscsi_rem(uint32_t crc, unsigned val, unsigned bits);
+
+// Compute the CRC a byte at a time.
+uint32_t crc32iscsi_byte(uint32_t crc, void const *mem, size_t len);
+
+// Compute the CRC a word at a time.
+uint32_t crc32iscsi_word(uint32_t crc, void const *mem, size_t len);
+
+// Compute the combination of two CRCs.
+uint32_t crc32iscsi_comb(uint32_t crc1, uint32_t crc2, uintmax_t len2);