Add phpstan and fix code

Author: icanhazstring

.travis.yml

@@ -16,6 +16,6 @@ before_script:
   - mkdir -p build/logs
 
 script:
-  - composer cs
+  - composer check
   - composer test -- --coverage-clover=build/logs/clover.xml --coverage-text
   - 'if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then ./vendor/bin/test-reporter; fi'

composer.json

@@ -11,7 +11,9 @@
         "phpunit/phpunit": "^6.1",
         "squizlabs/php_codesniffer": "^3.0",
         "codeclimate/php-test-reporter": "dev-master",
-        "adlawson/vfs": "^0.12.1"
+        "adlawson/vfs": "^0.12.1",
+        "phpstan/phpstan": "^0.9.2",
+        "jangregor/phpstan-prophecy": "^0.1.1"
     },
     "autoload": {
         "psr-4": {
@@ -35,7 +37,18 @@
         }
     ],
     "scripts": {
+        "check": [
+          "@php-cs-src",
+          "@php-cs-test",
+          "@phpstan-src",
+          "@phpstan-test"
+        ],
+
         "test": "vendor/bin/phpunit tests/",
-        "cs": "vendor/bin/phpcs --standard=PSR2 src/ && vendor/bin/phpcs --standard=PSR2 tests/"
+
+        "php-cs-src": "vendor/bin/phpcs --standard=PSR2 src/",
+        "php-cs-test": "vendor/bin/phpcs --standard=PSR2 tests/",
+        "phpstan-src": "vendor/bin/phpstan analyze --level=max src/",
+        "phpstan-test": "vendor/bin/phpstan analyze tests/ --level=4 -c phpstan.neon"
     }
 }

phpstan.neon

@@ -0,0 +1,6 @@
+includes:
+	- vendor/jangregor/phpstan-prophecy/src/extension.neon
+
+parameters:
+    ignoreErrors:
+        - '#Call to an undefined method SystemCtl\\Template\\Section\\InstallSection::setFubar\(\)#'

src/Command/CommandDispatcherInterface.php

@@ -35,10 +35,10 @@ public function setBinary(string $binary): CommandDispatcherInterface;
      * Dispatch given commands against implementers logic and creating a new command
      * to read results
      *
-     * @param string[] $commands
+     * @param string ...$commands
      *
      * @return CommandInterface
      * @throws CommandFailedException
      */
-    public function dispatch(...$commands): CommandInterface;
+    public function dispatch(string ...$commands): CommandInterface;
 }

src/Command/SymfonyCommandDispatcher.php

@@ -39,7 +39,7 @@ public function setTimeout(int $timeout): CommandDispatcherInterface
     /**
      * @inheritDoc
      */
-    public function dispatch(...$commands): CommandInterface
+    public function dispatch(string ...$commands): CommandInterface
     {
         $processBuilder = new ProcessBuilder();
         $processBuilder->setPrefix($this->binary);

src/SystemCtl.php

@@ -106,7 +106,7 @@ public static function setAssetPath(string $assetPath): void
      * @param null|string $unitPrefix
      * @param string[]    $unitTypes
      *
-     * @return array|\string[]
+     * @return array|string[]
      */
     public function listUnits(?string $unitPrefix = null, array $unitTypes = self::SUPPORTED_UNITS): array
     {
@@ -144,8 +144,8 @@ public function getService(string $name): Service
     }
 
     /**
-     * @param string  $unitName
-     * @param array[] $units
+     * @param string   $unitName
+     * @param string[] $units
      *
      * @return null|string
      */

src/Template/AbstractUnitTemplate.php

@@ -79,11 +79,11 @@ public function getSections(): array
     /**
      * Convert properties to proper definitions in templates
      *
-     * @param $properties
+     * @param string[] $properties
      *
-     * @return array
+     * @return string[]
      */
-    protected function convertProperties($properties)
+    protected function convertProperties(array $properties): array
     {
         return array_map([DefinitionConverter::class, 'convert'], $properties);
     }

src/Template/Section/AbstractSection.php

@@ -13,27 +13,27 @@
  */
 abstract class AbstractSection
 {
-    /** @var array */
+    /** @var string[] */
     protected $properties = [];
 
     protected const PROPERTIES = [];
 
     /**
-     * @return array
+     * @return string[]
      */
     public function getProperties(): array
     {
         return $this->properties;
     }
 
     /**
-     * @param $name
-     * @param $arguments
+     * @param string $name
+     * @param array $arguments
      *
      * @throws PropertyNotSupportedException
      * @return UnitSection|mixed
      */
-    public function __call($name, $arguments)
+    public function __call(string $name, array  $arguments)
     {
         preg_match('/(?<type>get|set)(?<property>.*)/', $name, $match);
 

src/Unit/AbstractUnit.php

@@ -73,11 +73,11 @@ public function getInstanceName(): ?string
     abstract protected function getUnitSuffix(): string;
 
     /**
-     * @param array $commands
+     * @param string ...$commands
      *
      * @return CommandInterface
      */
-    public function execute(...$commands): CommandInterface
+    public function execute(string ...$commands): CommandInterface
     {
         $commands[] = implode(
             '.',

src/Unit/UnitInterface.php

@@ -37,11 +37,11 @@ public function getInstanceName(): ?string;
     /**
      * Execute certain commands against the CommandDispatcher
      *
-     * @param array $commands
+     * @param string ...$commands
      *
      * @return CommandInterface
      */
-    public function execute(...$commands): CommandInterface;
+    public function execute(string ...$commands): CommandInterface;
 
     /**
      * Start command