Merge branch 'master' into 1.x

Author: icanhazstring

.travis.yml

@@ -18,4 +18,4 @@ before_script:
 script:
   - composer cs
   - composer test -- --coverage-clover=build/logs/clover.xml --coverage-text
-  - ./vendor/bin/test-reporter
+  - 'if [ "$TRAVIS_PULL_REQUEST" == "false" ]; then ./vendor/bin/test-reporter; fi'

Vagrantfile

@@ -4,6 +4,9 @@ Vagrant.configure("2") do |config|
   config.vm.provision "shell", inline: <<-SHELL
     add-apt-repository ppa:ondrej/php
     apt-get update
-    apt-get install -y php7.1 php7.1-xml php7.1-mbstring php7.1-zip composer
+    apt-get install -y php7.1 php7.1-xml php7.1-mbstring php7.1-zip php7.1-curl php7.1-xdebug composer
+
+    # Switch to /vagrant and install packages
+    cd /vagrant && composer install
   SHELL
 end

src/Command/CommandDispatcherInterface.php

@@ -0,0 +1,42 @@
+<?php
+
+namespace SystemCtl\Command;
+
+use SystemCtl\Exception\CommandFailedException;
+
+/**
+ * Interface CommandDispatcherInterface
+ *
+ * @package SystemCtl\Command
+ */
+interface CommandDispatcherInterface
+{
+    /**
+     * Timeout after which the dispatcher failes the execution
+     *
+     * @param int $timeout
+     *
+     * @return CommandDispatcherInterface
+     */
+    public function setTimeout(int $timeout): CommandDispatcherInterface;
+
+    /**
+     * Set basic binary to dispatch
+     *
+     * @param string $binary
+     *
+     * @return CommandDispatcherInterface
+     */
+    public function setBinary(string $binary): CommandDispatcherInterface;
+
+    /**
+     * Dispatch given commands against implementers logic and creating a new command
+     * to read results
+     *
+     * @param array $commands
+     *
+     * @return CommandInterface
+     * @throws CommandFailedException
+     */
+    public function dispatch(...$commands): CommandInterface;
+}

src/Command/CommandInterface.php

@@ -0,0 +1,31 @@
+<?php
+
+
+namespace SystemCtl\Command;
+
+use SystemCtl\Exception\CommandFailedException;
+
+/**
+ * Interface CommandInterface
+ *
+ * @package SystemCtl\Command
+ * @author icanhazstring <[email protected]>
+ */
+interface CommandInterface
+{
+    /**
+     * @return CommandInterface
+     * @throws CommandFailedException
+     */
+    public function run(): CommandInterface;
+
+    /**
+     * @return string
+     */
+    public function getOutput(): string;
+
+    /**
+     * @return bool
+     */
+    public function isSuccessful(): bool;
+}

src/Command/SymfonyCommand.php

@@ -0,0 +1,53 @@
+<?php
+
+namespace SystemCtl\Command;
+
+use Symfony\Component\Process\Process;
+use SystemCtl\Exception\CommandFailedException;
+
+/**
+ * Class SymfonyCommand
+ *
+ * @package SystemCtl\Command
+ * @author icanhazstring <[email protected]>
+ */
+class SymfonyCommand implements CommandInterface
+{
+    /** @var Process */
+    private $process;
+
+    public function __construct(Process $process)
+    {
+        $this->process = $process;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function getOutput(): string
+    {
+        return $this->process->getOutput();
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function isSuccessful(): bool
+    {
+        return $this->process->isSuccessful();
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function run(): CommandInterface
+    {
+        $this->process->run();
+
+        if (!$this->process->isSuccessful()) {
+            throw new CommandFailedException($this->process->getErrorOutput());
+        }
+
+        return $this;
+    }
+}

src/Command/SymfonyCommandDispatcher.php

@@ -0,0 +1,52 @@
+<?php
+
+namespace SystemCtl\Command;
+
+use Symfony\Component\Process\ProcessBuilder;
+
+/**
+ * Class SymfonyCommandDispatcher
+ *
+ * @package SystemCtl\Command
+ * @author  icanhazstring <[email protected]>
+ */
+class SymfonyCommandDispatcher implements CommandDispatcherInterface
+{
+    private $binary;
+    private $timetout;
+
+    /**
+     * @inheritdoc
+     */
+    public function setBinary(string $binary): CommandDispatcherInterface
+    {
+        $this->binary = $binary;
+
+        return $this;
+    }
+
+    /**
+     * @inheritdoc
+     */
+    public function setTimeout(int $timeout): CommandDispatcherInterface
+    {
+        $this->timetout = $timeout;
+
+        return $this;
+    }
+
+    /**
+     * @inheritDoc
+     */
+    public function dispatch(...$commands): CommandInterface
+    {
+        $processBuilder = new ProcessBuilder();
+        $processBuilder->setPrefix($this->binary);
+        $processBuilder->setTimeout($this->timetout);
+        $processBuilder->setArguments($commands);
+
+        $process = new SymfonyCommand($processBuilder->getProcess());
+
+        return $process->run();
+    }
+}

src/Exception/CommandFailedException.php

@@ -3,26 +3,10 @@
 namespace SystemCtl\Exception;
 
 /**
- * CommandFailedException
- *
- * @method static CommandFailedException fromService(string $unitName, string $command)
- * @method static CommandFailedException fromTimer(string $unitName, string $command)
+ * Class CommandFailedException
  *
  * @package SystemCtl\Exception
- *
- * @author icanhazstring <[email protected]>
  */
 class CommandFailedException extends \Exception
 {
-    public static function __callStatic($name, $arguments)
-    {
-        preg_match('/from(?<unit>.*)/', $name, $match);
-
-        $unit = strtolower($match['unit']);
-
-        $unitName = $arguments[0];
-        $command = $arguments[1];
-
-        return new self("Failed to {$command} {$unit} {$unitName}");
-    }
 }

src/Exception/ExceptionInterface.php

@@ -0,0 +1,14 @@
+<?php
+
+namespace SystemCtl\Exception;
+
+use Throwable;
+
+/**
+ * Interface ExceptionInterface
+ *
+ * @package SystemCtl\Exception
+ */
+interface ExceptionInterface extends Throwable
+{
+}

src/Exception/UnitNotFoundException.php

@@ -0,0 +1,26 @@
+<?php
+
+namespace SystemCtl\Exception;
+
+use RuntimeException;
+
+/**
+ * Class UnitNotFoundException
+ *
+ * @package SystemCtl\Exception
+ */
+class UnitNotFoundException extends RuntimeException implements ExceptionInterface
+{
+    /**
+     * @param string $type
+     * @param string $name
+     *
+     * @return UnitNotFoundException
+     */
+    public static function create(string $type, string $name): self
+    {
+        return new self(
+            sprintf('Could not find %s "%s"', ucfirst($type), $name)
+        );
+    }
+}

src/Exception/UnitTypeNotSupportedException.php

@@ -2,6 +2,11 @@
 
 namespace SystemCtl\Exception;
 
+/**
+ * Class UnitTypeNotSupportedException
+ *
+ * @package SystemCtl\Exception
+ */
 class UnitTypeNotSupportedException extends \Exception
 {
 }