Review mysql upgrade script:

- set CREATE_ID and MOD_ID to the constant value 'schema_upgrade',
- also set MOD_ID and MOD_TIME when setting a PID value in SAMPLE,
- use prefix '_local' in the PID values set in SAMPLE.

Still need to review the oracle upgrade script accordingly.

Author: RKrahl

src/main/scripts/upgrade_mysql_7_0.sql

@@ -21,7 +21,7 @@ DELIMITER //
 
 CREATE PROCEDURE SET_SAMPLES_PID()
 BEGIN
-    UPDATE SAMPLE SET PID = CONCAT('local:', LPAD(ID, 8, '0')) WHERE PID IS NULL;
+    UPDATE SAMPLE SET PID = CONCAT('_local:', LPAD(ID, 8, '0')), MOD_ID = 'schema_upgrade', MOD_TIME = NOW() WHERE PID IS NULL;
 END; //
 
 DELIMITER ;
@@ -37,21 +37,19 @@ DELIMITER //
 CREATE PROCEDURE MOVE_SAMPLE_INVESTIGATION_RELATIONS()
 BEGIN
     DECLARE done BOOLEAN DEFAULT FALSE;
-    DECLARE _createid VARCHAR(255);
-    DECLARE _modid VARCHAR(255);
     DECLARE _invid BIGINT;
     DECLARE _id BIGINT;
-    DECLARE cur CURSOR FOR SELECT CREATE_ID, MOD_ID, INVESTIGATION_ID, ID FROM SAMPLE;
+    DECLARE cur CURSOR FOR SELECT INVESTIGATION_ID, ID FROM SAMPLE;
     DECLARE CONTINUE HANDLER FOR NOT FOUND SET done := TRUE;
 
     OPEN cur;
     sampleLoop: LOOP
-        FETCH cur INTO _createid, _modid, _invid, _id;
+        FETCH cur INTO _invid, _id;
         IF done THEN
         LEAVE sampleLoop;
         END IF;
 
-        INSERT INTO INVESTIGATIONSAMPLE (CREATE_ID, CREATE_TIME, MOD_ID, MOD_TIME, INVESTIGATION_ID, SAMPLE_ID) VALUES (_createid, NOW(), _modid, NOW(), _invid, _id);
+        INSERT INTO INVESTIGATIONSAMPLE (CREATE_ID, CREATE_TIME, MOD_ID, MOD_TIME, INVESTIGATION_ID, SAMPLE_ID) VALUES ('schema_upgrade', NOW(), 'schema_upgrade', NOW(), _invid, _id);
     END LOOP sampleLoop;
     CLOSE cur;
 END; //