Parse times including time zones from ical.

Author: barelyknown

lib/ice_cube/parsers/ical_parser.rb

@@ -5,14 +5,17 @@ def self.schedule_from_ical(ical_string, options = {})
       ical_string.each_line do |line|
         (property, value) = line.split(':')
         (property, tzid) = property.split(';')
+        tz = _tz_from_tzid(tzid)
         case property
         when 'DTSTART'
-          data[:start_time] = Time.parse(value)
+          data[:start_time] = Time.parse(value).in_time_zone(tz)
         when 'DTEND'
-          data[:end_time] = Time.parse(value)
+          data[:end_time] = Time.parse(value).in_time_zone(tz)
         when 'EXDATE'
           data[:extimes] ||= []
-          data[:extimes] += value.split(',').map{|v| Time.parse(v)}
+          data[:extimes] += value.split(',').map do |v|
+            Time.parse(value).in_time_zone(tz)
+          end
         when 'DURATION'
           data[:duration] # FIXME
         when 'RRULE'
@@ -22,6 +25,14 @@ def self.schedule_from_ical(ical_string, options = {})
       Schedule.from_hash data
     end
 
+    def self._tz_from_tzid(tzid)
+      time_zone_name = case tzid
+      when /TZID=/ then tzid.split("=")[1]
+      else "UTC"
+      end
+      ActiveSupport::TimeZone[time_zone_name]
+    end
+
     def self.rule_from_ical(ical)
       params = { validations: { } }
 

spec/examples/from_ical_spec.rb

@@ -102,7 +102,14 @@ module IceCube
   RRULE:FREQ=WEEKLY;BYDAY=TH;UNTIL=20130531T100000Z
   ICAL
 
-    ical_string_woth_multiple_exdates = <<-ICAL.gsub(/^\s*/, '')
+    ical_string_with_time_zones = <<-ICAL.gsub(/^\s*/,'')
+  DTSTART;TZID=America/Denver:20130731T143000
+  DTEND:20130731T153000
+  RRULE:FREQ=WEEKLY
+  EXDATE;TZID=America/Chicago:20130823T143000
+  ICAL
+
+    ical_string_with_multiple_exdates = <<-ICAL.gsub(/^\s*/, '')
   DTSTART;TZID=America/Denver:20130731T143000
   DTEND;TZID=America/Denver:20130731T153000
   RRULE:FREQ=WEEKLY;UNTIL=20140730T203000Z;BYDAY=MO,WE,FR
@@ -125,6 +132,20 @@ def sorted_ical(ical)
       it "loads an ICAL string" do
         expect(IceCube::Schedule.from_ical(ical_string)).to be_a(IceCube::Schedule)
       end
+      describe "parsing time zones" do
+        it "sets the time zone of the start time" do
+          schedule = IceCube::Schedule.from_ical(ical_string_with_time_zones)
+          expect(schedule.start_time.time_zone).to eq ActiveSupport::TimeZone.new("America/Denver")
+        end
+        it "sets the time zone of the end time to UTC if none provided" do
+          schedule = IceCube::Schedule.from_ical(ical_string_with_time_zones)
+          expect(schedule.end_time.time_zone).to eq ActiveSupport::TimeZone.new("UTC")
+        end
+        it "sets the time zone of the exception times" do
+          schedule = IceCube::Schedule.from_ical(ical_string_with_time_zones)
+          expect(schedule.exception_times[0].time_zone).to eq ActiveSupport::TimeZone.new("America/Chicago")
+        end
+      end
     end
 
     describe "daily frequency" do
@@ -359,7 +380,7 @@ def sorted_ical(ical)
       end
 
       it 'handles multiple EXDATE lines' do
-        schedule = IceCube::Schedule.from_ical ical_string_woth_multiple_exdates
+        schedule = IceCube::Schedule.from_ical ical_string_with_multiple_exdates
         schedule.exception_times.count.should == 3
       end
     end