Skip to content

Commit dfdf6db

Browse files
committed
Unusable methods should fail
1 parent efd98f1 commit dfdf6db

File tree

1 file changed

+2
-4
lines changed

1 file changed

+2
-4
lines changed

lib/ice_cube/rule.rb

Lines changed: 2 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -23,9 +23,8 @@ def hash
2323
h.nil? ? super : h.hash
2424
end
2525

26-
# Expected to be overridden by subclasses
2726
def to_ical
28-
nil
27+
raise MethodNotImplemented, "Expected to be overrridden by subclasses"
2928
end
3029

3130
# Yaml implementation
@@ -38,9 +37,8 @@ def self.from_yaml(yaml)
3837
from_hash YAML::load(yaml)
3938
end
4039

41-
# Expected to be overridden by subclasses
4240
def to_hash
43-
nil
41+
raise MethodNotImplemented, "Expected to be overridden by subclasses"
4442
end
4543

4644
# Convert from a hash and create a rule

0 commit comments

Comments
 (0)