style: clippy autofix

Author: icecreammatt

src/ffmpeg.rs

@@ -24,7 +24,7 @@ fn run_command(command: &str) {
 
 pub fn create_preview_image(input: String, output: String) {
     let path = format!("{}/lg", output);
-    if !fs::metadata(&path).is_ok() {
+    if fs::metadata(&path).is_err() {
         fs::create_dir_all(&path).unwrap();
     }
 
@@ -42,7 +42,7 @@ pub fn create_thumbnails(input: String, output: String) {
     let thumbs_path = format!("{}/thumbs", output);
 
     println!("Path: {}", thumbs_path);
-    if !fs::metadata(&thumbs_path).is_ok() {
+    if fs::metadata(&thumbs_path).is_err() {
         fs::create_dir_all(&thumbs_path).unwrap();
     }
 
@@ -57,7 +57,7 @@ pub fn create_thumbnails(input: String, output: String) {
 pub fn create_hls_encoding(input: String, output: String) {
     println!("\npub create_hls_encoding");
 
-    if !fs::metadata(&output).is_ok() {
+    if fs::metadata(&output).is_err() {
         fs::create_dir_all(&output).unwrap();
     }
 

src/fileio.rs

@@ -4,13 +4,13 @@ use std::fs::File;
 use std::io::Write;
 
 pub fn file_to_hyphen(name: &String) -> String {
-    return String::from(name.replace("_", "-").replace(" ", "-").replace(".", "-"));
+    name.replace(['_', ' ', '.'], "-")
 }
 
 pub fn write_metadata(data: &OutputMetadata) {
     let directory = file_to_hyphen(&data.title);
 
-    if !fs::metadata(&directory).is_ok() {
+    if fs::metadata(&directory).is_err() {
         fs::create_dir(&directory).unwrap();
     }
 

src/main.rs

@@ -91,7 +91,7 @@ fn main() {
         process::exit(1);
     }
 
-    let out = media_info::get_media_info(&input);
+    let out = media_info::get_media_info(input);
     println!("{:#?}", &out);
     fileio::write_metadata(&out);
 
@@ -109,7 +109,7 @@ fn main() {
 
     let gen_hls = matches.is_present(Flags::HLS.as_str());
     if gen_hls {
-        create_hls_encoding(out.file_name.clone(), path.clone());
+        create_hls_encoding(out.file_name, path);
     }
 
     /*

src/media_info.rs

@@ -16,7 +16,7 @@ fn get_file_parts(file: &str) -> (&str, &str, &str) {
 }
 
 pub fn get_media_info(input: &str) -> OutputMetadata {
-    if !fs::metadata(&input).is_ok() {
+    if fs::metadata(input).is_err() {
         println!("{} is not found.", &input);
         std::process::exit(1);
     }
@@ -25,7 +25,7 @@ pub fn get_media_info(input: &str) -> OutputMetadata {
 
     let media_info = Command::new("mediainfo")
         .arg("--output=JSON")
-        .arg(format!("{}", input))
+        .arg(input)
         .output()
         .expect("mediainfo error parsing file, make sure mediainfo is installed");
 
@@ -75,7 +75,7 @@ pub fn get_media_info(input: &str) -> OutputMetadata {
         }
     }
 
-    return metadata;
+    metadata
 }
 
 #[test]