Skip to content

Commit 4f59985

Browse files
Merge pull request #237 from icecube/fix236
Use only package level loggers
2 parents 9cf1aed + b93069e commit 4f59985

File tree

2 files changed

+7
-7
lines changed

2 files changed

+7
-7
lines changed

skyllh/core/debugging.py

Lines changed: 0 additions & 4 deletions
Original file line numberDiff line numberDiff line change
@@ -5,10 +5,6 @@
55
import sys
66

77

8-
# Initialize the root logger.
9-
logging.root.setLevel(logging.NOTSET)
10-
11-
128
def get_logger(
139
name):
1410
"""Retrieves the logger with the given name from the Python logging system.

skyllh/scripting/logging.py

Lines changed: 7 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -8,6 +8,7 @@
88

99
from skyllh.core.debugging import (
1010
get_logger,
11+
setup_logger,
1112
setup_console_handler,
1213
setup_file_handler,
1314
)
@@ -19,9 +20,9 @@ def setup_logging(
1920
log_format=None,
2021
log_level=logging.INFO,
2122
debug_pathfilename=None):
22-
"""Installs console handlers for the ``skyllh`` and ``script_logger_name``
23-
loggers. If a debug file is specified, file handlers for debug messages
24-
will be installed as well.
23+
"""Initializes loggers and installs console handlers for the ``skyllh`` and
24+
``script_logger_name`` loggers. If a debug file is specified, file handlers
25+
for debug messages will be installed as well.
2526
2627
Parameters
2728
----------
@@ -46,6 +47,9 @@ def setup_logging(
4647
if log_format is None:
4748
log_format = cfg['debugging']['log_format']
4849

50+
setup_logger('skyllh', log_level)
51+
setup_logger(script_logger_name, log_level)
52+
4953
setup_console_handler(
5054
cfg=cfg,
5155
name='skyllh',

0 commit comments

Comments
 (0)