Skip to content

Commit 6b8b945

Browse files
🐛 Fix reactivity between expense processing and travel authorization expense claim aproval tables.
1 parent d5a3abf commit 6b8b945

File tree

3 files changed

+9
-7
lines changed

3 files changed

+9
-7
lines changed

web/src/components/expenses/ExpensesProcessingDataTable.vue

Lines changed: 5 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -226,10 +226,10 @@ async function approveExpense(expenseId: number): Promise<void> {
226226
try {
227227
await api.expenses.approveApi.create(expenseId)
228228
snack.success("Expense approved!")
229-
emit("approved", expenseId)
229+
refresh()
230230
231231
await nextTick()
232-
refresh()
232+
emit("approved", expenseId)
233233
} finally {
234234
isProcessingExpenseMap.value.set(expenseId, false)
235235
}
@@ -239,8 +239,10 @@ function openExpenseRejectDialog(expenseId: number): void {
239239
expenseRejectDialogRef.value?.open(expenseId)
240240
}
241241
242-
function refreshAndEmitRejected(expenseId: number): void {
242+
async function refreshAndEmitRejected(expenseId: number): Promise<void> {
243243
refresh()
244+
245+
await nextTick()
244246
emit("rejected", expenseId)
245247
}
246248

web/src/components/travel-authorizations/finance/TravelAuthorizationsExpenseClaimApprovedDataTable.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -184,10 +184,10 @@ async function approveTravelAuthorization(travelAuthorizationId: number): Promis
184184
try {
185185
await travelAuthorizationsApi.expense(travelAuthorizationId)
186186
snack.success("Travel authorization expensed!")
187-
emit("expensed", travelAuthorizationId)
187+
refresh()
188188
189189
await nextTick()
190-
refresh()
190+
emit("expensed", travelAuthorizationId)
191191
} finally {
192192
isProcessingTravelAuthorizationMap.value.set(travelAuthorizationId, false)
193193
}

web/src/pages/ExpenseProcessingPage.vue

Lines changed: 2 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -8,7 +8,7 @@
88
<ExpensesProcessingCard
99
ref="expensesProcessingCardRef"
1010
class="default"
11-
@updated="refreshExpenseProcessingCard"
11+
@updated="refreshTravelAuthorizationsExpenseClaimApprovedCard"
1212
/>
1313
</v-col>
1414
</v-row>
@@ -17,7 +17,7 @@
1717
<TravelAuthorizationsExpenseClaimApprovedCard
1818
ref="travelAuthorizationsExpenseClaimApprovedCardRef"
1919
class="default mt-5"
20-
@updated="refreshTravelAuthorizationsExpenseClaimApprovedCard"
20+
@updated="refreshExpenseProcessingCard"
2121
/>
2222
</v-col>
2323
</v-row>

0 commit comments

Comments
 (0)