Skip to content

Commit 5467304

Browse files
authored
Disable parsing advancements to fix 1.12.2 Forge SevTech crash (#148) (#149)
Leave the advancements packet as an opaque blob for now instead of trying to deserialize it, because it apparently is changed on some modded servers - see #148
1 parent 1a600c7 commit 5467304

File tree

1 file changed

+4
-0
lines changed

1 file changed

+4
-0
lines changed

protocol/src/protocol/packet.rs

Lines changed: 4 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -1706,10 +1706,14 @@ state_packets!(
17061706
field pitch: i8 =,
17071707
}
17081708
packet Advancements {
1709+
field data: Vec<u8> =,
1710+
/* TODO: fix parsing modded advancements 1.12.2 (e.g. SevTech Ages)
1711+
* see https://github.com/iceiix/stevenarella/issues/148
17091712
field reset_clear: bool =,
17101713
field mapping: LenPrefixed<VarInt, packet::Advancement> =,
17111714
field identifiers: LenPrefixed<VarInt, String> =,
17121715
field progress: LenPrefixed<VarInt, packet::AdvancementProgress> =,
1716+
*/
17131717
}
17141718
/// EntityProperties updates the properties for an entity.
17151719
packet EntityProperties {

0 commit comments

Comments
 (0)