fix issue edit resource on no resource searches

Author: icepick4

onepyece/common.py

@@ -33,6 +33,8 @@ def check_params(endpoint, search=None, resource=None):
         raise ValueError(f"Unknown search '{search}' for endpoint '{endpoint}'")
     if search is not None and search not in NO_RESOURCE_SEARCHES and resource is None:
         raise ValueError("Resource is required for this search")
+    if search in [NO_RESOURCE_SEARCHES] and resource is not None:
+        raise ValueError("Resource is not required for this search")
     if resource is not None and "id" in search and not isinstance(resource, int):
         raise ValueError("Resource must be an integer for this search")
     return None

tests/__main__.py

@@ -1,8 +1,8 @@
 import unittest
 
-from .test_api import *
-from .test_common import *
-from .test_functions import *
+# from .test_api import *
+# from .test_common import *
+# from .test_functions import *
 from .test_interface import *
 
 if __name__ == '__main__':

tests/test_interface.py

@@ -76,3 +76,12 @@ def test_edit_resource(self):
         self.assertEqual(api_object.french_name, 'Monkey D Luffy')
         api_object.edit_resource('zoro')
         self.assertEqual(api_object.french_name, 'Roronoa Zoro')
+
+    def test_edit_resource_not_allowed(self):
+        api_object = interface.API('characters', 'count')
+        api_object_2 = interface.API('crews', 'yonko')
+        with self.assertRaises(ValueError):
+            api_object.edit_resource('zoro')
+        with self.assertRaises(ValueError):
+            api_object_2.edit_resource('zoro')
+