fixing endpoint issue in the api

Author: icepick4

onepyece/__init__.py

@@ -16,7 +16,7 @@
     "chapter_by_title",
     "count_chapters",
     "arc_by_id",
-    # "arc_by_title",
+    "arc_by_title",
     "arc_by_saga_id",
     "count_arcs",
     "saga_by_id",

onepyece/common.py

@@ -6,7 +6,7 @@
     "movies": ["id", "count", "title"],
     "tomes": ["id", "count", "title"],
     "chapters": ["id", "count", "title", "tome_id"],
-    "arcs": ["id", "count", "saga_id"],
+    "arcs": ["id", "count", "title", "saga_id"],
     "sagas": ["id", "count", "title"],
     "hakis": ["id", "count", "name", "roman_name", "characters_id"],
     "characters": ["id", "count", "name", "job", "bounty", "status", "size", "crew_id", "fruit_id"],
@@ -51,7 +51,8 @@ def build_url(endpoint, search=None, resource=None):
 
 
 def adding_search(endpoint, search, resource=None):
-    if search in STRING_SEARCHES:
+    # This is a special case cause the API endpoints are weird
+    if search in STRING_SEARCHES or search == "title" and endpoint == "arcs": 
         return f"{URL}{endpoint}/search/{search}/{resource}"
     elif search in NO_SEARCH_ID_SEARCHES and endpoint not in ['boats', 'arcs']:
         return f"{URL}{endpoint}/{search[:-3]}/{resource}"

onepyece/functions.py

@@ -68,9 +68,9 @@ def count_chapters():
 def arc_by_id(resource):
     return API("arcs", "id", resource)
 
-# This functions is not working because the API link is not working
-# def arc_by_title(resource):
-#     return API("arcs", "title", resource)
+
+def arc_by_title(resource):
+    return API("arcs", "title", resource)
 
 
 def arc_by_saga_id(resource):

tests/__main__.py

@@ -1,8 +1,8 @@
 import unittest
 
-# from .test_api import *
-# from .test_common import *
-# from .test_functions import *
+from .test_api import *
+from .test_common import *
+from .test_functions import *
 from .test_interface import *
 
 if __name__ == '__main__':

tests/test_interface.py

@@ -84,4 +84,16 @@ def test_edit_resource_not_allowed(self):
             api_object.edit_resource('zoro')
         with self.assertRaises(ValueError):
             api_object_2.edit_resource('zoro')
-        
+
+    def test_edit_resource_attributes(self):
+        api_object = interface.API('characters', 'name', 'luffy')
+        self.assertEqual(api_object.french_name, 'Monkey D Luffy')
+        self.assertEqual(api_object.url, 'https://api.api-onepiece.com/characters/search/name/luffy')
+        api_object.edit_resource('zoro')
+        self.assertEqual(api_object.french_name, 'Roronoa Zoro')
+        self.assertEqual(api_object.url, 'https://api.api-onepiece.com/characters/search/name/zoro')
+
+    def test_edit_resource_with_wrong_resource(self):
+        api_object = interface.API('characters', 'name', 'luffy')
+        with self.assertRaises(ValueError):
+            api_object.edit_resource('wrong')