add JavaScriptEngineTest (not working), review fixes

Author: Tetraquark

buildSrc/src/main/kotlin/Deps.kt

@@ -13,13 +13,14 @@ object Deps {
 
     private const val coroutinesVersion = "1.4.2"
     private const val kotlinxSerializationVersion = "1.1.0"
-    private const val mokoTestVersion = "0.2.0"
+    private const val mokoTestVersion = "0.3.0"
+
     const val mokoJavascriptVersion = "0.1.0"
 
     object Android {
         const val compileSdk = 30
         const val targetSdk = 30
-        const val minSdk = 16
+        const val minSdk = 18
     }
 
     object Libs {
@@ -37,7 +38,13 @@ object Deps {
             const val kotlinSerialization =
                 "org.jetbrains.kotlinx:kotlinx-serialization-json:$kotlinxSerializationVersion"
 
-            const val mokoTest = "dev.icerock.moko:test:$mokoTestVersion"
+            const val kotlinTest =
+                "org.jetbrains.kotlin:kotlin-test-common:$kotlinTestVersion"
+            const val kotlinTestAnnotations =
+                "org.jetbrains.kotlin:kotlin-test-annotations-common:$kotlinTestVersion"
+            const val mokoTest = "dev.icerock.moko:test-core:$mokoTestVersion"
+            const val mokoTestRobolectric = "dev.icerock.moko:test-roboelectric:$mokoTestVersion"
+
             const val mokoJavascript = "dev.icerock.moko:javascript:$mokoJavascriptVersion"
         }
     }

javascript/build.gradle.kts

@@ -7,10 +7,24 @@ plugins {
     id("publication-convention")
 }
 
+android {
+    testOptions.unitTests.isIncludeAndroidResources = true
+    defaultConfig {
+        testInstrumentationRunner = "androidx.test.runner.AndroidJUnitRunner"
+    }
+}
+
 dependencies {
     androidMainImplementation(Deps.Libs.Android.quickjs)
 
     commonMainImplementation(Deps.Libs.MultiPlatform.kotlinSerialization)
 
+    commonTestImplementation(Deps.Libs.MultiPlatform.kotlinTest)
+    commonTestImplementation(Deps.Libs.MultiPlatform.kotlinTestAnnotations)
     commonTestImplementation(Deps.Libs.MultiPlatform.mokoTest)
+
+    androidTestImplementation("androidx.test:runner:1.3.0")
+    androidTestImplementation("androidx.test:rules:1.3.0")
+    androidTestImplementation("androidx.test.ext:junit:1.1.2")
+    androidTestImplementation("androidx.test.ext:junit-ktx:1.1.2")
 }

javascript/src/androidAndroidTest/kotlin/dev/icerock/moko/javascript/JavaScriptEngineTest.kt

@@ -0,0 +1,40 @@
+/*
+ * Copyright 2021 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license.
+ */
+
+package dev.icerock.moko.javascript
+
+import org.junit.After
+import org.junit.Before
+import org.junit.Test
+
+class JavaScriptEngineTest {
+    private var _javaScriptEngine: JavaScriptEngine? = null
+
+    private val javaScriptEngine: JavaScriptEngine
+        get() = _javaScriptEngine!!
+
+    @Before
+    fun init() {
+        _javaScriptEngine = JavaScriptEngine()
+    }
+
+    @After
+    fun dispose() {
+        javaScriptEngine.close()
+    }
+
+    @Test
+    fun equalityTest() {
+        val jsScript = """
+            var a = 1 + 2;
+            a
+        """.trimIndent()
+        val result = javaScriptEngine.evaluate(emptyMap(), jsScript)
+
+        println("DBG $result")
+
+        //assertTrue { result is JsType.IntNum }
+        //assertEquals(expected = 3, actual = result.intValue())
+    }
+}

javascript/src/androidMain/kotlin/dev/icerock/moko/javascript/JavaScriptEngine.kt

@@ -49,21 +49,20 @@ actual class JavaScriptEngine actual constructor(){
     }
 
     private fun handleQuickJsResult(result: Any?): JsType {
-        if (result is String) {
-            return try {
-                JsType.Json(json.encodeToJsonElement(result))
-            } catch (ex: SerializationException) {
-                JsType.Str(result)
-            }
-        }
-
         return when (result) {
             result == null -> JsType.Null
             is Boolean -> JsType.Bool(result)
             is Int -> JsType.IntNum(result)
             is Double -> JsType.DoubleNum(result)
             is Float -> JsType.DoubleNum(result.toDouble())
-            else -> throw IllegalStateException("Impossible JavaScriptEngine handler state")
+            is String -> try {
+                JsType.Json(json.encodeToJsonElement(result))
+            } catch (ex: SerializationException) {
+                JsType.Str(result)
+            }
+            else -> throw JavaScriptEvaluationException(
+                message = "Impossible JavaScriptEngine handler state with result [$result]"
+            )
         }
     }
 }

javascript/src/commonMain/kotlin/dev/icerock/moko/javascript/JsType.kt

@@ -18,3 +18,10 @@ sealed class JsType {
      */
     object Null : JsType()
 }
+
+fun JsType.boolValue(): Boolean = (this as JsType.Bool).value
+fun JsType.stringValue(): String = (this as JsType.Str).value
+fun JsType.intValue(): Int = (this as JsType.IntNum).value
+fun JsType.doubleValue(): Double = (this as JsType.DoubleNum).value
+fun JsType.jsonValue(): JsonElement = (this as JsType.Json).value
+fun JsType.nullValue(): Any? = (this as JsType.Null).let { null }

sample/android-app/src/main/AndroidManifest.xml

@@ -6,7 +6,7 @@
     <uses-permission android:name="android.permission.INTERNET" />
 
     <application
-        android:label="moko-fields test app"
+        android:label="moko-javascript test app"
         android:theme="@style/Theme.AppCompat.DayNight"
         tools:ignore="GoogleAppIndexingWarning">
 

sample/mpp-library/src/commonMain/kotlin/com/icerockdev/library/Calculator.kt

@@ -4,10 +4,6 @@
 
 package com.icerockdev.library
 
-import dev.icerock.moko.javascript.multiply
-
 class Calculator {
-    fun run() {
-        println(multiply(a = 2, b = 3))
-    }
+    fun run() = Unit
 }