review fixes

Author: Alex009

.github/workflows/compilation-check.yml

@@ -8,14 +8,14 @@ on:
 
 jobs:
   build:
-    runs-on: macOS-11
+    runs-on: macOS-latest
 
     steps:
       - uses: actions/checkout@v1
-      - name: Set up JDK 11
+      - name: Set up JDK 17
         uses: actions/setup-java@v1
         with:
-          java-version: 11
+          java-version: 17
       - name: Check plugin
         run: ./gradlew -p network-generator build publishToMavenLocal
       - name: Check runtime

.github/workflows/publish.yml

@@ -11,7 +11,7 @@ on:
 jobs:
   publish:
     name: Publish library at mavenCentral
-    runs-on: macOS-11
+    runs-on: macOS-latest
     env:
       OSSRH_USER: ${{ secrets.OSSRH_USER }}
       OSSRH_KEY: ${{ secrets.OSSRH_KEY }}
@@ -21,14 +21,21 @@ jobs:
 
     steps:
       - uses: actions/checkout@v1
-      - name: Set up JDK 11
+      - name: Set up JDK 17
         uses: actions/setup-java@v1
         with:
-          java-version: 11
-      - name: Publish plugin
-        run: ./gradlew -p network-generator publishPlugins -Pgradle.publish.key=${{ secrets.GRADLE_PLUGIN_PORTAL_KEY }} -Pgradle.publish.secret=${{ secrets.GRADLE_PLUGIN_PORTAL_SECRET }}
+          java-version: 17
+      - name: Prebuild plugin
+        run: ./gradlew -p network-generator publishToMavenLocal
+      - name: Prebuild library
+        run: ./gradlew publishToMavenLocal
       - name: Publish library
-        run: ./gradlew publish
+        run: ./gradlew publishToSonatype closeAndReleaseSonatypeStagingRepository
+      - name: Publish plugin to maven central
+        run: ./gradlew -p network-generator publishToSonatype closeAndReleaseSonatypeStagingRepository
+      - name: Publish plugin to Gradle Plugin Portal
+        run: ./gradlew -p network-generator publishPlugins -Pgradle.publish.key=${{ secrets.GRADLE_PLUGIN_PORTAL_KEY }} -Pgradle.publish.secret=${{ secrets.GRADLE_PLUGIN_PORTAL_SECRET }}
+
   release:
     name: Create release
     needs: publish

.gitignore

@@ -4,6 +4,7 @@
 .classpath
 .vscode
 .idea
+.kotlin
 build
 *.iml
 Pods

README.md

@@ -36,7 +36,7 @@ buildscript {
     }
 
     dependencies {
-        classpath "dev.icerock.moko:network-generator:0.21.2"
+        classpath "dev.icerock.moko:network-generator:0.22.0"
     }
 }
 
@@ -53,10 +53,10 @@ project build.gradle
 apply plugin: "dev.icerock.mobile.multiplatform-network-generator"
 
 dependencies {
-    commonMainApi("dev.icerock.moko:network:0.21.2")
-    commonMainApi("dev.icerock.moko:network-engine:0.21.2") // configured HttpClientEngine
-    commonMainApi("dev.icerock.moko:network-bignum:0.21.2") // kbignum serializer
-    commonMainApi("dev.icerock.moko:network-errors:0.21.2") // moko-errors integration
+    commonMainApi("dev.icerock.moko:network:0.22.0")
+    commonMainApi("dev.icerock.moko:network-engine:0.22.0") // configured HttpClientEngine
+    commonMainApi("dev.icerock.moko:network-bignum:0.22.0") // kbignum serializer
+    commonMainApi("dev.icerock.moko:network-errors:0.22.0") // moko-errors integration
 }
 ```
 

build.gradle.kts

@@ -1,7 +1,6 @@
 /*
  * Copyright 2019 IceRock MAG Inc. Use of this source code is governed by the Apache 2.0 license.
  */
-import org.gradle.api.internal.artifacts.DefaultModuleVersionSelector
 
 buildscript {
     repositories {
@@ -25,17 +24,6 @@ val mokoVersion = libs.versions.mokoNetworkVersion.get()
 allprojects {
     this.group = "dev.icerock.moko"
     this.version = mokoVersion
-
-    configurations.configureEach {
-        resolutionStrategy {
-            val coroutines: MinimalExternalModuleDependency = rootProject.libs.coroutines.get()
-            val forcedCoroutines: ModuleVersionSelector = DefaultModuleVersionSelector.newSelector(
-                coroutines.module,
-                coroutines.versionConstraint.requiredVersion
-            )
-            force(forcedCoroutines)
-        }
-    }
 }
 
 tasks.register("clean", Delete::class).configure {

gradle.properties

@@ -14,8 +14,8 @@ mobile.multiplatform.iosTargetWarning=false
 
 xcodeproj=./sample/ios-app
 
-moko.android.targetSdk=35
-moko.android.compileSdk=35
+moko.android.targetSdk=34
+moko.android.compileSdk=34
 moko.android.minSdk=16
 
 moko.publish.name=MOKO network

gradle/libs.versions.toml

@@ -20,7 +20,7 @@ mokoResourcesVersion = "0.24.4"
 mokoMvvmVersion = "0.16.0"
 mokoErrorsVersion = "0.7.0"
 mokoTestVersion = "0.6.1"
-mokoNetworkVersion = "0.21.2"
+mokoNetworkVersion = "0.22.0"
 
 # tests
 espressoCoreVersion = "3.5.1"
@@ -30,15 +30,15 @@ androidxTestVersion = "1.5.0"
 robolectricVersion = "4.9"
 
 # other
-ktorClientVersion = "3.0.0"
+ktorVersion = "3.0.0"
 kbignumVersion = "2.4.12"
 multidexVersion = "2.0.1"
 
 [libraries]
 # android
 appCompat = { module = "androidx.appcompat:appcompat", version.ref = "androidAppCompatVersion" }
 glide = { module = "com.github.bumptech.glide:glide", version.ref = "glideVersion" }
-lifecycleViewModel =  { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "lifecycleViewModelVersion" }
+lifecycleViewModel = { module = "androidx.lifecycle:lifecycle-viewmodel-ktx", version.ref = "lifecycleViewModelVersion" }
 multidex = { module = "androidx.multidex:multidex", version.ref = "multidexVersion" }
 coreKtx = { module = "androidx.core:core-ktx", version.ref = "coreKtxVersion" }
 
@@ -47,22 +47,26 @@ kotlinSerialization = { module = "org.jetbrains.kotlinx:kotlinx-serialization-js
 coroutines = { module = "org.jetbrains.kotlinx:kotlinx-coroutines-core", version.ref = "coroutinesVersion" }
 
 # ktor
-ktorClientOkHttp = { module = "io.ktor:ktor-client-okhttp", version.ref = "ktorClientVersion" }
-ktorClient = { module = "io.ktor:ktor-client-core", version.ref = "ktorClientVersion" }
-ktorClientLogging = { module = "io.ktor:ktor-client-logging", version.ref = "ktorClientVersion" }
-ktorClientWebSocket = { module = "io.ktor:ktor-client-websockets", version.ref = "ktorClientVersion" }
-ktorClientMock = { module = "io.ktor:ktor-client-mock", version.ref = "ktorClientVersion" }
-ktorClientIos =  { module = "io.ktor:ktor-client-ios", version.ref = "ktorClientVersion" }
+ktorClientOkHttp = { module = "io.ktor:ktor-client-okhttp", version.ref = "ktorVersion" }
+ktorClient = { module = "io.ktor:ktor-client-core", version.ref = "ktorVersion" }
+ktorClientLogging = { module = "io.ktor:ktor-client-logging", version.ref = "ktorVersion" }
+ktorClientWebSocket = { module = "io.ktor:ktor-client-websockets", version.ref = "ktorVersion" }
+ktorClientMock = { module = "io.ktor:ktor-client-mock", version.ref = "ktorVersion" }
+ktorClientIos = { module = "io.ktor:ktor-client-ios", version.ref = "ktorVersion" }
+
+ktorServerNetty = { module = "io.ktor:ktor-server-netty", version.ref = "ktorVersion" }
+ktorServerCore = { module = "io.ktor:ktor-server-core", version.ref = "ktorVersion" }
+ktorServerWebSockets = { module = "io.ktor:ktor-server-websockets", version.ref = "ktorVersion" }
 
 # korlibs
-kbignum =  { module = "com.soywiz.korlibs.kbignum:kbignum", version.ref = "kbignumVersion" }
+kbignum = { module = "com.soywiz.korlibs.kbignum:kbignum", version.ref = "kbignumVersion" }
 
 # moko
-mokoMvvmDataBinding =  { module = "dev.icerock.moko:mvvm-databinding", version.ref = "mokoMvvmVersion" }
+mokoMvvmDataBinding = { module = "dev.icerock.moko:mvvm-databinding", version.ref = "mokoMvvmVersion" }
 mokoResources = { module = "dev.icerock.moko:resources", version.ref = "mokoResourcesVersion" }
 mokoMvvmCore = { module = "dev.icerock.moko:mvvm-core", version.ref = "mokoMvvmVersion" }
 mokoMvvmLiveData = { module = "dev.icerock.moko:mvvm-livedata", version.ref = "mokoMvvmVersion" }
-mokoErrors =  { module = "dev.icerock.moko:errors", version.ref = "mokoErrorsVersion" }
+mokoErrors = { module = "dev.icerock.moko:errors", version.ref = "mokoErrorsVersion" }
 
 # tests
 espressoCore = { module = "androidx.test.espresso:espresso-core", version.ref = "espressoCoreVersion" }
@@ -72,16 +76,17 @@ robolectric = { module = "org.robolectric:robolectric", version.ref = "robolectr
 testRunner = { module = "androidx.test:runner", version.ref = "testRunnerVersion" }
 testRules = { module = "androidx.test:rules", version.ref = "testRunnerVersion" }
 testExtJunit = { module = "androidx.test.ext:junit", version.ref = "testExtJunitVersion" }
-kotlinTestAnnotations = { module = "org.jetbrains.kotlin:kotlin-test-annotations-common", version.ref = "kotlinVersion" }
-mokoTest =  { module = "dev.icerock.moko:test-core", version.ref = "mokoTestVersion" }
+kotlinTest = { module = "org.jetbrains.kotlin:kotlin-test", version.ref = "kotlinVersion" }
+mokoTest = { module = "dev.icerock.moko:test-core", version.ref = "mokoTestVersion" }
 
 # jvm
 openApiGenerator = { module = "org.openapitools:openapi-generator-gradle-plugin", version.ref = "openApiGeneratorVersion" }
 guava = { module = "com.google.guava:guava", version.ref = "guavaVersion" }
+logback = { module = "ch.qos.logback:logback-classic", version = "1.5.21" }
 
 # gradle plugins
 kotlinGradlePlugin = { module = "org.jetbrains.kotlin:kotlin-gradle-plugin", version.ref = "kotlinVersion" }
 kotlinSerializationGradlePlugin = { module = "org.jetbrains.kotlin:kotlin-serialization", version.ref = "kotlinVersion" }
-androidGradlePlugin = { module = "com.android.tools.build:gradle", version = "8.7.3" }
+androidGradlePlugin = { module = "com.android.tools.build:gradle", version = "8.5.2" }
 mokoResourcesGradlePlugin = { module = "dev.icerock.moko:resources-generator", version.ref = "mokoResourcesVersion" }
-mokoGradlePlugin = { module = "dev.icerock.moko:moko-gradle-plugin", version = "0.5.1" }
+mokoGradlePlugin = { module = "dev.icerock.moko:moko-gradle-plugin", version = "0.6.0" }

network-bignum/build.gradle.kts

@@ -14,14 +14,12 @@ android {
 }
 
 kotlin {
-    jvmToolchain(17)
-
     jvm()
 }
 
 dependencies {
     commonMainImplementation(libs.kotlinSerialization)
     commonMainApi(libs.kbignum)
 
-    commonMainImplementation(project(":network"))
+    commonMainImplementation(projects.network)
 }

network-engine/build.gradle.kts

@@ -15,8 +15,6 @@ android {
 }
 
 kotlin {
-    jvmToolchain(17)
-
     jvm()
 
     sourceSets {
@@ -41,6 +39,6 @@ kotlin {
 
 dependencies {
     commonMainImplementation(libs.coroutines)
-    commonMainApi(project(":network"))
+    commonMainApi(projects.network)
     iosMainApi(libs.ktorClientIos)
 }

network-errors/build.gradle.kts

@@ -14,17 +14,18 @@ android {
     namespace = "dev.icerock.moko.network.errors"
 }
 
-kotlin {
-    jvmToolchain(17)
-}
-
 dependencies {
     commonMainImplementation(libs.kotlinSerialization)
 
     commonMainApi(libs.mokoErrors)
     commonMainApi(libs.mokoResources)
 
-    commonMainImplementation(project(":network"))
+    commonMainImplementation(projects.network)
+
+    // temporary workaround for
+    // e: KLIB resolver: Could not find "dev.icerock.moko:parcelize
+    // caused moko-errors
+    iosMainApi("dev.icerock.moko:parcelize:0.9.0")
 }
 
 multiplatformResources {