Skip to content

Commit f2789e2

Browse files
authored
Merge pull request #851 from kenkoro/fix/443-themed-color-resource
The obsolete TODO marks inside themed color resources
2 parents 910bae1 + da50ca1 commit f2789e2

File tree

3 files changed

+1
-5
lines changed

3 files changed

+1
-5
lines changed

README.md

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -134,7 +134,7 @@ should [add `export` declarations](https://kotlinlang.org/docs/multiplatform-bui
134134
```
135135
framework {
136136
export("dev.icerock.moko:resources:0.25.1")
137-
export("dev.icerock.moko:graphics:0.9.0") // toUIColor here
137+
export("dev.icerock.moko:graphics:0.10.0") // toUIColor here
138138
}
139139
```
140140

resources-compose/src/iosMain/kotlin/dev/icerock/moko/resources/compose/ColorResource.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -22,8 +22,6 @@ import platform.UIKit.UIColor
2222
@OptIn(ExperimentalForeignApi::class)
2323
@Composable
2424
actual fun colorResource(resource: ColorResource): Color {
25-
// TODO https://github.com/icerockdev/moko-resources/issues/443
26-
// recompose when appearance changed (now not works in runtime!)
2725
val darkMode: Boolean = isSystemInDarkTheme()
2826
return remember(resource, darkMode) {
2927
val uiColor: UIColor = resource.getUIColor()

resources-compose/src/macosMain/kotlin/dev/icerock/moko/resources/compose/ColorResource.kt

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -15,8 +15,6 @@ import platform.AppKit.NSColorSpace.Companion.deviceRGBColorSpace
1515

1616
@Composable
1717
actual fun colorResource(resource: ColorResource): Color {
18-
// TODO https://github.com/icerockdev/moko-resources/issues/443
19-
// recompose when appearance changed (now not works in runtime!)
2018
val darkMode: Boolean = isSystemInDarkTheme()
2119
return remember(resource, darkMode) {
2220
val nsColor: NSColor = resource.getNSColor()

0 commit comments

Comments
 (0)