[asset-system] Pass asset names not StringID's to the AssetShelve 'store' method.

Author: Dandielo

source/code/systems/asset_system/private/asset_shelve.cxx

@@ -61,7 +61,7 @@ namespace ice
     }
 
     auto AssetShelve::store(
-        ice::StringID_Arg name,
+        ice::String name,
         ice::ResourceHandle const& resource
     ) noexcept -> ice::AssetEntry*
     {
@@ -72,7 +72,7 @@ namespace ice
         ice::u64 const name_hash = ice::hash(name);
         if constexpr (ice::AssetEntry::HoldsDebugData)
         {
-            ice::HeapString<> asset_name{ _allocator, ice::stringid_hint(name) };
+            ice::HeapString<> asset_name{ _allocator, name };
 
             ice::hashmap::set(
                 _asset_resources,
@@ -96,7 +96,7 @@ namespace ice
     }
 
     auto AssetShelve::store(
-        ice::StringID_Arg name,
+        ice::String name,
         ice::AssetDataBinding const& data_binding
     ) noexcept -> ice::AssetEntry*
     {
@@ -111,7 +111,7 @@ namespace ice
         ice::u64 const name_hash = ice::hash(name);
         if constexpr (ice::AssetEntry::HoldsDebugData)
         {
-            ice::HeapString<> asset_name{ _allocator, ice::stringid_hint(name) };
+            ice::HeapString<> asset_name{ _allocator, name };
 
             ice::hashmap::set(
                 _asset_resources,

source/code/systems/asset_system/private/asset_shelve.hxx

@@ -36,12 +36,12 @@ namespace ice
         ) const noexcept -> ice::AssetEntry const*;
 
         auto store(
-            ice::StringID_Arg name,
+            ice::String name,
             ice::ResourceHandle const& resource_handle
         ) noexcept -> ice::AssetEntry*;
 
         auto store(
-            ice::StringID_Arg name,
+            ice::String name,
             ice::AssetDataBinding const& data_binding
         ) noexcept -> ice::AssetEntry*;
 

source/code/systems/asset_system/private/asset_storage.cxx

@@ -322,7 +322,7 @@ namespace ice
             if (resource_handle.valid())
             {
                 // Create a new asset entry if the handle exists
-                entry = shelve->store(ice::stringid(name), resource_handle);
+                entry = shelve->store(name, resource_handle);
                 ICE_ASSERT_CORE(entry != nullptr);
 
                 //ice::u32 const prev_count = entry->_refcount.fetch_add(1, std::memory_order_relaxed);
@@ -379,7 +379,7 @@ namespace ice
         else if (shelve != nullptr)
         {
             // Create a new asset entry if the handle exists
-            entry = shelve->store(ice::stringid(name), data_binding);
+            entry = shelve->store(name, data_binding);
             ICE_ASSERT_CORE(entry != nullptr);
 
             //ice::u32 const prev_count = entry->_refcount.fetch_add(1, std::memory_order_relaxed);