AndroidStudio compatibility (#192)

With these changes we fully support the AndroidStudio IDE, files have proper intellisense, builds work, and debugging is seamless (if you have symbols in your binaries)

Features:
* Support for AndroidStudio.
* Access to all C++ source files from all projects.
* Improved 'ICE_ASSERT_CORE' to support constexpr contexts.
* Updated NDK to version 28.1, which builds by default with 16KiB page support.
* Retargeted Android examples to API Level 35

Fixes:
* Fixed threads platform feature was missing AIOPort object.
* Fixed aligned allocation crash by using 'posix_memalign' instead of 'aligned_alloc'.
* Fixed various missing-symbol errors at runtime.

Improvements:
* Added linker flag to check for missing symbols during linking. (-Wl,-z,defs)
* Added assertion to URI parsing. (including constexpr contexts)
* Added assertion to Shard creation. (including constexpr contexts)

Other
* Tested and executed on Android emulators (x64-16KiB and armv8-4KiB)

Author: Dandielo

.github/workflows/build-validate-android.yaml

@@ -17,7 +17,7 @@ jobs:
     strategy:
       matrix:
         project: [all]
-        pipeline: [Android29-ARMv8, Android29-x64]
+        pipeline: [Android35-ARMv8,Android35-x64]
         config: [Debug,Develop,Profile,Release]
     with:
       host-platform: 'windows-latest'

source/code/core/core/public/ice/assert_core.hxx

@@ -8,24 +8,42 @@
 #include <cassert>
 #undef assert
 
+namespace ice::detail
+{
+
+    // The following function will fail to access element at index [2] only in constexpr scenarios and when the expression is false.
+    // This is good enough for us to create an assertion macro for constexpr and non-constexpr cases.
+    constexpr char _iceshard_constexpr_assert(bool v) noexcept
+    {
+        int cev = std::is_constant_evaluated();
+        char constexpr_assert_failure[2]{ };
+        return constexpr_assert_failure[!v + cev];
+    };
+
+} // namespace ice::detail::assert
+
 #if ISP_WINDOWS
 
 #define ICE_ASSERT_CORE(expression) do { if (std::is_constant_evaluated() == false) { \
         (void)(                                                                                 \
             (!!(expression)) ||                                                                 \
             (_wassert(_CRT_WIDE(#expression), _CRT_WIDE(__FILE__), (unsigned)(__LINE__)), 0)    \
-        ); } } while(false)
+        ); } else { ice::detail::_iceshard_constexpr_assert(expression); } } while(false)
 
 #elif ISP_WEBAPP || ISP_LINUX
 
-#define ICE_ASSERT_CORE(expression) ((expression) \
-    ? (void)0 \
-    : __assert_fail(#expression, __FILE__, __LINE__, __PRETTY_FUNCTION__))
+#define ICE_ASSERT_CORE(expression) do { if (std::is_constant_evaluated() == false) { \
+    ((expression) \
+        ? (void)0 \
+        : __assert_fail(#expression, __FILE__, __LINE__, __PRETTY_FUNCTION__)); \
+    } else { ice::detail::_iceshard_constexpr_assert(expression); } } while(false)
 
 #else
 
-#define ICE_ASSERT_CORE(expression) ((expression) \
-    ? __assert_no_op \
-    : __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, #expression))
+#define ICE_ASSERT_CORE(expression) do { if (std::is_constant_evaluated() == false) { \
+    ((expression) \
+        ? __assert_no_op \
+        : __assert2(__FILE__, __LINE__, __PRETTY_FUNCTION__, #expression)); \
+    } else { ice::detail::_iceshard_constexpr_assert(expression); } } while(false)
 
 #endif

source/code/core/core/public/ice/shard.hxx

@@ -238,11 +238,7 @@ namespace ice
         ice::Shard result{ };
         ice::ShardID const id = ice::shardid(definition);
 
-        if (std::is_constant_evaluated() == false)
-        {
-            ICE_ASSERT_CORE(id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet);
-        }
-
+        ICE_ASSERT_CORE(id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet);
         if (id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet)
         {
             result.id = id;
@@ -257,11 +253,7 @@ namespace ice
     {
         ice::Shard result{ };
 
-        if (std::is_constant_evaluated() == false)
-        {
-            ICE_ASSERT_CORE(id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet);
-        }
-
+        ICE_ASSERT_CORE(id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet);
         if (id.payload == ice::Constant_ShardPayloadID<T> || id.payload == ice::ShardPayloadID_NotSet)
         {
             result.id = id;

source/code/core/memsys/private/mem.cxx

@@ -46,7 +46,7 @@ namespace ice
             .size = size,
             .alignment = alignment,
         };
-#elif ISP_LINUX || ISP_WEBAPP || (ISP_ANDROID && ISP_ANDROID <= 29)
+#elif ISP_LINUX || ISP_WEBAPP || (ISP_ANDROID && ISP_ANDROID <= 35)
         void* memory_location;
 
         [[maybe_unused]]

source/code/core/tasks/private/task_thread_utils.cxx

@@ -1,3 +1,6 @@
+/// Copyright 2025 - 2025, Dandielo <dandielo@iceshard.net>
+/// SPDX-License-Identifier: MIT
+
 #include <ice/task_thread_utils.hxx>
 #include <ice/os/windows.hxx>
 #include <ice/os/unix.hxx>

source/code/core/tasks/public/ice/task_thread_utils.hxx

@@ -1,3 +1,6 @@
+/// Copyright 2025 - 2025, Dandielo <dandielo@iceshard.net>
+/// SPDX-License-Identifier: MIT
+
 #pragma once
 #include <ice/base.hxx>
 #include <ice/clock_types.hxx>

source/code/core/utils/private/config/config_builder_types.hxx

@@ -5,6 +5,7 @@
 #include "config_internal.hxx"
 #include <ice/config/config_builder.hxx>
 #include <ice/string/heap_var_string.hxx>
+#include <ice/string/heap_string.hxx>
 #include <ice/container/array.hxx>
 
 namespace ice::config::detail

source/code/example/android/simple/build.gradle.template.kts

@@ -6,10 +6,12 @@ plugins {
 android {
     // Here we use TargetSDK to have possible access to newer APIs
     compileSdk = $(TargetSDK)
-    // buildToolsVersion = "$ (AndroidBuildToolsVersion)"
 
     namespace = "$(Namespace)"
 
+    // Defines the NDK version to be used for this project
+    ndkVersion = "$(NDKVersion)"
+
     defaultConfig {
 
         // Uniquely identifies the package for publishing.
@@ -27,6 +29,16 @@ android {
 
         // Defines a user-friendly version name for your app.
         versionName = "$(VersionName)"
+
+        // By default keep debug symbols, just remove it in release afterwards
+        packaging.jniLibs.keepDebugSymbols += "**/*.so"
+
+        $(IBTBuildSystemIntegration)
+    }
+
+    compileOptions {
+        targetCompatibility = JavaVersion.VERSION_11
+        sourceCompatibility = JavaVersion.VERSION_11
     }
 
     buildTypes {
@@ -51,39 +63,13 @@ android {
 
         $(ProjectJNISources)
     }
-}
-
-afterEvaluate {
-    /**
-     * IBT Integration for FastBuild build system.
-     *  To properly handle our build system, we create a new additional tasks that mimic the behavior of built-in CMakeBuild / NdkBuild steps.
-     *  Because gradle requires the outputs to be stored in a sub-folder with a specific ABI name, IBT is handling this by default.
-     *
-     * NOTE: Currently only ARM64 is supported as a value ABI target using the default IBT Pipeline.
-     *  You can add additional ABI support by calling the proper pipeline for the given ABI.
-     */
-    android.buildTypes.configureEach {
-        val buildConfig = this.name.replaceFirstChar { it.titlecase() }
-        val buildPipeline = "Android$(CompileSDK)"
-        val abiList = listOf("ARMv8", "x64")
-
-        var abiTargets = emptyArray<String>()
-        for (abi in abiList)
-        {
-            abiTargets += "-t"
-            abiTargets += "all-${buildPipeline}-${abi}-${buildConfig}"
-        }
 
-        val fbuildTask = tasks.register<Exec>("compile${buildConfig}UsingFastbuild") {
-            workingDir("$(WorkspaceDir)")
-            executable("$(WorkspaceDir)/$(ScriptFile)")
-            commandLine(listOf("$(WorkspaceDir)/$(ScriptFile)", "build") + abiTargets)
-        }
-        tasks["merge${buildConfig}NativeLibs"].dependsOn(fbuildTask)
+    lint {
+        baseline = file("lint-baseline.xml")
     }
 }
 
 dependencies {
-    implementation("androidx.appcompat:appcompat:1.6.1")
+    implementation("androidx.appcompat:appcompat:1.7.1")
     implementation(fileTree(mapOf("dir" to "libs", "include" to listOf("*.jar"))))
 }

source/code/example/android/simple/private/example_android.cxx

@@ -47,6 +47,7 @@ struct TestTrait : public ice::Trait
 
     TestTrait(ice::TraitContext& context) noexcept
         : ice::Trait{ context }
+        , timer{ }
     {
         _context.bind<&TestTrait::logic>();
         _context.bind<&TestTrait::gfx>(ice::gfx::ShardID_GfxFrameUpdate);

source/code/example/android/simple/simple.bff

@@ -19,14 +19,14 @@
         .Namespace = 'net.example.simple'
         .ApplicationID = 'net.example.myapp'
 
-        .TargetSDK = '34'
+        .TargetSDK = '36'
         // .MinSDK = '28' This comes from the Pipeline AndroidAPILevel value
 
         .VersionCode = 142
         .VersionName = '1.4.2'
 
         .GradlePlugins = {
-            'id("com.android.application") version "8.2.0"'
+            'id("com.android.application") version "8.10.1"'
             'id("org.jetbrains.kotlin.android") version "1.8.20"'
         }
     ]
@@ -43,6 +43,7 @@
                 'vulkan_renderer'
                 'iceshard_pipelines'
                 'imgui_module'
+                'shader_tools'
             }
         ]