Merge pull request #25 from ichiro-its/miscellaneous-changes

Miscellaneous changes

Author: threeal

.github/workflows/build-and-test.yml

@@ -1,16 +1,18 @@
 name: Build and Test
 on:
+  workflow_dispatch:
   pull_request:
-    branches: [ master ]
+    branches: [master]
   push:
-    branches: [ master ]
+    branches: [master]
 jobs:
   build-and-test:
     runs-on: ubuntu-latest
     steps:
-      - name: Checking out
+      - name: Checkout this repository
         uses: actions/checkout@v2.3.4
-      - name: Building and testing
-        uses: ichiro-its/ros2-ci@v1.0.0
         with:
-          ros2-distro: foxy
+          path: musen
+
+      - name: Build and test workspace
+        uses: ichiro-its/ros2-build-and-test-action@main

.github/workflows/deploy-debian-nightly.yml

@@ -0,0 +1,41 @@
+name: Deploy Debian Nightly
+on:
+  workflow_dispatch:
+  push:
+    branches: [master]
+jobs:
+  deploy-debian-nightly:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout this repository
+        uses: actions/checkout@v2.3.4
+        with:
+          path: musen
+
+      - name: Build nightly Debian package
+        uses: ichiro-its/ros2-build-debian-action@main
+        with:
+          unique-version: true
+
+      - name: Deploy nightly Debian package to server
+        uses: appleboy/scp-action@master
+        with:
+          host: ${{ secrets.SSH_HOST }}
+          port: ${{ secrets.SSH_PORT }}
+          username: ${{ secrets.SSH_USER }}
+          password: ${{ secrets.SSH_PASS }}
+          source: "package/*.deb"
+          target: "~/temp/nightly/musen/"
+          rm: true
+
+      - name: Prepare nightly Debian package in the server
+        uses: appleboy/ssh-action@master
+        with:
+          host: ${{ secrets.SSH_HOST }}
+          port: ${{ secrets.SSH_PORT }}
+          username: ${{ secrets.SSH_USER }}
+          password: ${{ secrets.SSH_PASS }}
+          script: |
+            cd ~/repository/debian
+            reprepro includedeb nightly ~/temp/nightly/musen/package/*.deb
+            rm -rf ~/temp/nightly/musen/

.github/workflows/deploy-debian-stable.yml

@@ -0,0 +1,39 @@
+name: Deploy Debian Stable
+on:
+  workflow_dispatch:
+  release:
+    types: [created]
+jobs:
+  deploy-debian-stable:
+    runs-on: ubuntu-latest
+    steps:
+      - name: Checkout this repository
+        uses: actions/checkout@v2.3.4
+        with:
+          path: musen
+
+      - name: Build stable Debian package
+        uses: ichiro-its/ros2-build-debian-action@main
+
+      - name: Deploy stable Debian package to server
+        uses: appleboy/scp-action@master
+        with:
+          host: ${{ secrets.SSH_HOST }}
+          port: ${{ secrets.SSH_PORT }}
+          username: ${{ secrets.SSH_USER }}
+          password: ${{ secrets.SSH_PASS }}
+          source: "package/*.deb"
+          target: "~/temp/stable/musen/"
+          rm: true
+
+      - name: Prepare stable Debian package in the server
+        uses: appleboy/ssh-action@master
+        with:
+          host: ${{ secrets.SSH_HOST }}
+          port: ${{ secrets.SSH_PORT }}
+          username: ${{ secrets.SSH_USER }}
+          password: ${{ secrets.SSH_PASS }}
+          script: |
+            cd ~/repository/debian
+            reprepro includedeb stable ~/temp/stable/musen/package/*.deb
+            rm -rf ~/temp/stable/musen/

README.md

@@ -2,9 +2,10 @@
 
 [![latest version](https://img.shields.io/github/v/release/ichiro-its/musen)](https://github.com/ichiro-its/musen/releases/)
 [![commits since latest version](https://img.shields.io/github/commits-since/ichiro-its/musen/latest)](https://github.com/ichiro-its/musen/commits/master)
-[![milestone](https://img.shields.io/github/milestones/progress/ichiro-its/musen/1?label=milestone)](https://github.com/ichiro-its/musen/milestone/2)
 [![license](https://img.shields.io/github/license/ichiro-its/musen)](./LICENSE)
-[![build and test status](https://img.shields.io/github/workflow/status/ichiro-its/musen/Build%20and%20Test?label=build%20and%20test)](https://github.com/ichiro-its/musen/actions)
+[![test status](https://img.shields.io/github/workflow/status/ichiro-its/musen/Build%20and%20Test?label=test)](https://github.com/ichiro-its/musen/actions)
+[![deploy stable status](https://img.shields.io/github/workflow/status/ichiro-its/musen/Deploy%20Debian%20Stable?label=deploy%20stable)](https://repository.ichiro-its.org/)
+[![deploy nightly status](https://img.shields.io/github/workflow/status/ichiro-its/musen/Deploy%20Debian%20Nightly?label=deploy%20nightly)](https://repository.ichiro-its.org/)
 
 Musen (無線, wireless) is a [ROS 2](https://docs.ros.org/en/foxy/index.html) package that provides a [UDP](https://en.wikipedia.org/wiki/User_Datagram_Protocol) broadcast communication library for a ROS 2 project.
 This package is written in C++ and currently only works on Linux based operating system.
@@ -25,7 +26,7 @@ In this package, the broadcast communication will be handled by a Broadcaster ob
 ### Binary Packages
 
 - See [releases](https://github.com/ichiro-its/musen/releases) for the latest version of this package.
-- Alternatively, this package is available on [ICHIRO ITS Repository](https://repository.ichiro-its.org/) as a `ros-foxy-musen` package.
+- Alternatively, this package also available on [ICHIRO ITS Repository](https://repository.ichiro-its.org/) as `ros-foxy-musen` package.
 
 ### Build From Source
 

include/musen/broadcaster/base_broadcaster.hpp

@@ -23,35 +23,46 @@
 
 #include <arpa/inet.h>
 
-#include <string>
 #include <list>
+#include <memory>
+#include <string>
 
 #include "../udp_socket.hpp"
 
 namespace musen
 {
 
-class BaseBroadcaster : public UdpSocket
+class BaseBroadcaster
 {
 public:
-  explicit BaseBroadcaster(const int & port);
+  explicit BaseBroadcaster(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>());
+
+  bool connect();
+  bool disconnect();
 
-  int send(const void * data, const int & length);
+  int send(const char * data, const int & length);
 
   void enable_broadcast(const bool & enable);
   void add_target_host(const std::string & host);
 
+  std::shared_ptr<UdpSocket> get_udp_socket() const;
+
   const int & get_port() const;
 
 protected:
-  std::list<struct sockaddr_in> get_recipent_sas() const;
-  std::list<struct sockaddr_in> get_recipent_sas_from_broadcast_ifas() const;
-  std::list<struct sockaddr_in> get_recipent_sas_from_target_hosts() const;
+  std::list<struct sockaddr_in> obtain_recipent_sas() const;
+  std::list<struct sockaddr_in> obtain_recipent_sas_from_broadcast_ifas() const;
+  std::list<struct sockaddr_in> obtain_recipent_sas_from_target_hosts() const;
+
+  std::shared_ptr<UdpSocket> udp_socket;
 
   bool broadcast;
   std::list<std::string> target_hosts;
 
   int port;
+
+  std::list<struct sockaddr_in> recipent_sas;
 };
 
 }  // namespace musen

include/musen/broadcaster/broadcaster.hpp

@@ -21,6 +21,8 @@
 #ifndef MUSEN__BROADCASTER__BROADCASTER_HPP_
 #define MUSEN__BROADCASTER__BROADCASTER_HPP_
 
+#include <memory>
+
 #include "./base_broadcaster.hpp"
 
 namespace musen
@@ -30,14 +32,15 @@ template<typename T>
 class Broadcaster : public BaseBroadcaster
 {
 public:
-  explicit Broadcaster(const int & port)
-  : BaseBroadcaster(port)
+  explicit Broadcaster(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>())
+  : BaseBroadcaster(port, udp_socket)
   {
   }
 
   int send(const T & data)
   {
-    return BaseBroadcaster::send(&data, sizeof(data));
+    return BaseBroadcaster::send((const char *)&data, sizeof(data));
   }
 };
 

include/musen/broadcaster/string_broadcaster.hpp

@@ -21,6 +21,7 @@
 #ifndef MUSEN__BROADCASTER__STRING_BROADCASTER_HPP_
 #define MUSEN__BROADCASTER__STRING_BROADCASTER_HPP_
 
+#include <memory>
 #include <string>
 #include <vector>
 
@@ -32,7 +33,8 @@ namespace musen
 class StringBroadcaster : public BaseBroadcaster
 {
 public:
-  explicit StringBroadcaster(const int & port);
+  explicit StringBroadcaster(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>());
 
   int send(const std::string & message);
   int send(const std::vector<std::string> & messages, const std::string & delimiter = ",");

include/musen/listener/base_listener.hpp

@@ -21,6 +21,8 @@
 #ifndef MUSEN__LISTENER__BASE_LISTENER_HPP_
 #define MUSEN__LISTENER__BASE_LISTENER_HPP_
 
+#include <memory>
+
 #include "../udp_socket.hpp"
 
 namespace musen
@@ -29,15 +31,21 @@ namespace musen
 class BaseListener : public UdpSocket
 {
 public:
-  explicit BaseListener(const int & port);
+  explicit BaseListener(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>());
 
-  bool connect() override;
+  bool connect();
+  bool disconnect();
 
   int receive(void * buffer, const int & length);
 
+  std::shared_ptr<UdpSocket> get_udp_socket() const;
+
   const int & get_port() const;
 
 protected:
+  std::shared_ptr<UdpSocket> udp_socket;
+
   int port;
 };
 

include/musen/listener/listener.hpp

@@ -32,8 +32,9 @@ template<typename T>
 class Listener : public BaseListener
 {
 public:
-  explicit Listener(const int & port)
-  : BaseListener(port)
+  explicit Listener(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>())
+  : BaseListener(port, udp_socket)
   {
   }
 

include/musen/listener/string_listener.hpp

@@ -21,6 +21,7 @@
 #ifndef MUSEN__LISTENER__STRING_LISTENER_HPP_
 #define MUSEN__LISTENER__STRING_LISTENER_HPP_
 
+#include <memory>
 #include <string>
 #include <vector>
 
@@ -32,7 +33,8 @@ namespace musen
 class StringListener : public BaseListener
 {
 public:
-  explicit StringListener(const int & port);
+  explicit StringListener(
+    const int & port, std::shared_ptr<UdpSocket> udp_socket = std::make_shared<UdpSocket>());
 
   std::string receive(const int & length);
   std::vector<std::string> receive(const int & length, const std::string & delimiter);