Skip to content

Commit ede445f

Browse files
committed
Update TestQueryPackage to test file:// urls
1 parent aeabf6b commit ede445f

File tree

1 file changed

+33
-13
lines changed

1 file changed

+33
-13
lines changed

internal/modproxy/modproxy_test.go

Lines changed: 33 additions & 13 deletions
Original file line numberDiff line numberDiff line change
@@ -393,7 +393,6 @@ func TestQueryPackage(t *testing.T) {
393393
}
394394
server := httptest.NewServer(proxy)
395395
defer server.Close()
396-
t.Setenv("GOPROXY", server.URL)
397396

398397
tests := []struct {
399398
name string
@@ -418,16 +417,37 @@ func TestQueryPackage(t *testing.T) {
418417
},
419418
}
420419

421-
for _, tt := range tests {
422-
t.Run(tt.name, func(t *testing.T) {
423-
mod, err := QueryPackage(tt.pkgpath, false)
424-
if err != nil {
425-
t.Fatal(err)
426-
}
427-
if !reflect.DeepEqual(mod, tt.want) {
428-
t.Fatalf("QueryPackage() = %+v, want %+v", mod, tt.want)
429-
}
430-
})
431-
}
432-
}
420+
t.Run("http", func(t *testing.T) {
421+
t.Setenv("GOPROXY", server.URL)
422+
for _, tt := range tests {
423+
t.Run(tt.name, func(t *testing.T) {
424+
mod, err := QueryPackage(tt.pkgpath, false)
425+
if err != nil {
426+
t.Fatal(err)
427+
}
428+
if !reflect.DeepEqual(mod, tt.want) {
429+
t.Fatalf("QueryPackage() = %+v, want %+v", mod, tt.want)
430+
}
431+
})
432+
}
433+
})
433434

435+
t.Run("file", func(t *testing.T) {
436+
tmpDir := t.TempDir()
437+
if err := proxy.WriteToDir(tmpDir); err != nil {
438+
t.Fatal(err)
439+
}
440+
t.Setenv("GOPROXY", "file://"+tmpDir)
441+
for _, tt := range tests {
442+
t.Run(tt.name, func(t *testing.T) {
443+
mod, err := QueryPackage(tt.pkgpath, false)
444+
if err != nil {
445+
t.Fatal(err)
446+
}
447+
if !reflect.DeepEqual(mod, tt.want) {
448+
t.Fatalf("QueryPackage() = %+v, want %+v", mod, tt.want)
449+
}
450+
})
451+
}
452+
})
453+
}

0 commit comments

Comments
 (0)