mcp validations

Author: masterkain

charts/mcp-server/examples/node-chrome-devtools-bridge.yaml

@@ -16,5 +16,9 @@ servers:
     register:
       enabled: false
 
+# Disable Unla subchart for this standalone example
+unla:
+  enabled: false
+
 # The mcp-proxy bridge keeps the stdio server alive and converts to HTTP transport
 # Gateway is managed by the Unla subchart (Service: <release-name>, port 5235)

charts/mcp-server/templates/_validation.yaml

@@ -0,0 +1,28 @@
+{{- /*
+Validation: if unla.enabled=false, no server may have register.enabled=true (default true).
+This prevents silently skipping registration while the user expects it.
+*/ -}}
+{{- $unla := .Values.unla -}}
+{{- $unlaDisabled := false -}}
+{{- if kindIs "map" $unla -}}
+  {{- if kindIs "bool" $unla.enabled -}}
+    {{- $unlaDisabled = (not $unla.enabled) -}}
+  {{- end -}}
+{{- end -}}
+{{- if $unlaDisabled -}}
+  {{- $bad := list -}}
+  {{- range $i, $s := (default (list) .Values.servers) -}}
+    {{- $reg := (get $s "register") -}}
+    {{- $regMap := ternary $reg (dict) (kindIs "map" $reg) -}}
+    {{- /* default register.enabled=true when omitted */ -}}
+    {{- $regEnabled := (default true ($regMap.enabled)) -}}
+    {{- if $regEnabled -}}
+      {{- $name := ($s.name | default (printf "srv-%d" $i)) -}}
+      {{- $bad = append $bad $name -}}
+    {{- end -}}
+  {{- end -}}
+  {{- if gt (len $bad) 0 -}}
+    {{- fail (printf "unla.enabled=false but these servers have register.enabled=true: %s. Either set unla.enabled=true or set register.enabled=false for these servers." (join ", " $bad)) -}}
+  {{- end -}}
+{{- end -}}
+

charts/mcp-server/templates/gateway-register-config.yaml

@@ -1,5 +1,20 @@
 {{- $hasServers := and (hasKey .Values "servers") (gt (len .Values.servers) 0) -}}
-{{- if and $hasServers (.Values.unla.enabled | default true) }}
+{{- $ctx := dict "hasReg" false -}}
+{{- range $i, $s := .Values.servers -}}
+  {{- $reg := (get $s "register") -}}
+  {{- $regMap := ternary $reg (dict) (kindIs "map" $reg) -}}
+  {{- $enabled := (default true ($regMap.enabled)) -}}
+  {{- if $enabled -}}
+    {{- $_ := set $ctx "hasReg" true -}}
+  {{- end -}}
+{{- end -}}
+{{- $unlaFlag := true -}}
+{{- if kindIs "map" .Values.unla -}}
+  {{- if kindIs "bool" .Values.unla.enabled -}}
+    {{- $unlaFlag = .Values.unla.enabled -}}
+  {{- end -}}
+{{- end -}}
+{{- if and $hasServers $unlaFlag ($ctx.hasReg) }}
 apiVersion: v1
 kind: ConfigMap
 metadata:

charts/mcp-server/templates/gateway-register-job.yaml

@@ -1,5 +1,20 @@
 {{- $hasServers := and (hasKey .Values "servers") (gt (len .Values.servers) 0) -}}
-{{- if and $hasServers (.Values.unla.enabled | default true) }}
+{{- $ctx := dict "hasReg" false -}}
+{{- range $i, $s := .Values.servers -}}
+  {{- $reg := (get $s "register") -}}
+  {{- $regMap := ternary $reg (dict) (kindIs "map" $reg) -}}
+  {{- $enabled := (default true ($regMap.enabled)) -}}
+  {{- if $enabled -}}
+    {{- $_ := set $ctx "hasReg" true -}}
+  {{- end -}}
+{{- end -}}
+{{- $unlaFlag := true -}}
+{{- if kindIs "map" .Values.unla -}}
+  {{- if kindIs "bool" .Values.unla.enabled -}}
+    {{- $unlaFlag = .Values.unla.enabled -}}
+  {{- end -}}
+{{- end -}}
+{{- if and $hasServers $unlaFlag ($ctx.hasReg) }}
 apiVersion: batch/v1
 kind: Job
 metadata: