Workaround VS caching issue - fixes #586

GrahamTheCoder · GrahamTheCoder · commit 3bfd76003f04 · 2020-07-04T11:48:01.000+01:00
diff --git a/CodeConverter/CSharp/ProjectExtensions.cs b/CodeConverter/CSharp/ProjectExtensions.cs
@@ -33,10 +33,12 @@ public static ProjectInfo ToProjectInfo(this Project project, ProjectId projectI
 
         public static Project ToProjectFromAnyOptions(this Project project, CompilationOptions compilationOptions, ParseOptions parseOptions)
         {
-            var projectInfo = project.ToProjectInfo(project.Id, project.Name, compilationOptions,
+            // Use a new id to workaround VS caching issue first reported here: https://github.com/icsharpcode/CodeConverter/issues/586
+            var newProjectId = ProjectId.CreateNewId("ConvertedProject");
+            var projectInfo = project.ToProjectInfo(newProjectId, project.Name, compilationOptions,
                 project.ProjectReferences, parseOptions);
             var convertedSolution = project.Solution.RemoveProject(project.Id).AddProject(projectInfo);
-            return convertedSolution.GetProject(project.Id);
+            return convertedSolution.GetProject(newProjectId);
         }
 
         public static string GetDirectoryPath(this Project proj)

Original file line number	Diff line number	Diff line change
`@@ -33,10 +33,12 @@ public static ProjectInfo ToProjectInfo(this Project project, ProjectId projectI`
`33`	`33`
`34`	`34`	`public static Project ToProjectFromAnyOptions(this Project project, CompilationOptions compilationOptions, ParseOptions parseOptions)`
`35`	`35`	`{`
`36`		`- var projectInfo = project.ToProjectInfo(project.Id, project.Name, compilationOptions,`
	`36`	`+ // Use a new id to workaround VS caching issue first reported here: https://github.com/icsharpcode/CodeConverter/issues/586`
	`37`	`+ var newProjectId = ProjectId.CreateNewId("ConvertedProject");`
	`38`	`+ var projectInfo = project.ToProjectInfo(newProjectId, project.Name, compilationOptions,`
`37`	`39`	`project.ProjectReferences, parseOptions);`
`38`	`40`	`var convertedSolution = project.Solution.RemoveProject(project.Id).AddProject(projectInfo);`
`39`		`- return convertedSolution.GetProject(project.Id);`
	`41`	`+ return convertedSolution.GetProject(newProjectId);`
`40`	`42`	`}`
`41`	`43`
`42`	`44`	`public static string GetDirectoryPath(this Project proj)`