Skip to content

Refactor for cross platform port (#3641) #2624

Refactor for cross platform port (#3641)

Refactor for cross platform port (#3641) #2624

Triggered via pull request December 31, 2025 08:51
Status Success
Total duration 3m 50s
Artifacts

codeql-analysis.yml

on: pull_request
Matrix: Analyze
Fit to window
Zoom out
Zoom in

Annotations

10 warnings
Analyze (csharp): ICSharpCode.Decompiler/Metadata/MetadataFile.cs#L288
get_SectionHeaders creates an exception of type BadImageFormatException, an exception type that should not be raised in a property. If this exception instance might be raised, use a different exception type, convert this property into a method, or change this property's logic so that it no longer raises an exception. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1065)
Analyze (csharp): ICSharpCode.Decompiler/Output/PlainTextOutput.cs#L31
Type 'PlainTextOutput' owns disposable field(s) 'writer' but is not disposable (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1001)
Analyze (csharp): ICSharpCode.Decompiler/Metadata/WebCilFile.cs#L35
Provide an overridable implementation of Dispose(bool) on 'WebCilFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Analyze (csharp): ICSharpCode.Decompiler/Metadata/PEFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'PEFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Analyze (csharp): ICSharpCode.Decompiler/Metadata/DotNetCorePathFinder.cs#L33
Move pinvokes to native methods class (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1060)
Analyze (csharp): ICSharpCode.Decompiler/Util/LongSet.cs#L31
Implement the equality operators and make their behavior identical to that of the Equals method (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca2231)
Analyze (csharp): ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Rename 'EmptyList.System.IDisposable.Dispose' to 'Dispose' and ensure that it is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Analyze (csharp): ICSharpCode.Decompiler/Util/EmptyList.cs#L102
Ensure that 'EmptyList.System.IDisposable.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Analyze (csharp): ICSharpCode.Decompiler/Util/ResXResourceWriter.cs#L307
Ensure that 'ResXResourceWriter.Dispose' is declared as public and sealed (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)
Analyze (csharp): ICSharpCode.Decompiler/Util/ResourcesFile.cs#L34
Provide an overridable implementation of Dispose(bool) on 'ResourcesFile' or mark the type as sealed. A call to Dispose(false) should only clean up native resources. A call to Dispose(true) should clean up both managed and native resources. (https://learn.microsoft.com/dotnet/fundamentals/code-analysis/quality-rules/ca1063)