Fix misplaced noWarn.Add

siegfriedpammer · siegfriedpammer · commit 1e4c9b300967 · 2025-12-02T21:32:48.000+01:00
diff --git a/ICSharpCode.Decompiler.Tests/Helpers/Tester.cs b/ICSharpCode.Decompiler.Tests/Helpers/Tester.cs
@@ -608,6 +608,7 @@ public static async Task<CompilerResults> CompileCSharp(string sourceFileName, C
 				if (flags.HasFlag(CompilerOptions.ProcessXmlDoc))
 				{
 					otherOptions += $"-doc:\"{Path.ChangeExtension(results.PathToAssembly, ".xml")}\" ";
+					noWarn.Add("CS1591"); // Missing XML comment for publicly visible type or member 'Type_or_Member'
 				}
 
 				if (flags.HasFlag(CompilerOptions.CheckForOverflowUnderflow))
@@ -622,7 +623,6 @@ public static async Task<CompilerResults> CompileCSharp(string sourceFileName, C
 				if (preprocessorSymbols.Count > 0)
 				{
 					otherOptions += " \"-d:" + string.Join(";", preprocessorSymbols) + "\" ";
-					noWarn.Add("CS1591");
 				}
 
 				if (noWarn.Count > 0)

Original file line number	Diff line number	Diff line change
`@@ -608,6 +608,7 @@ public static async Task<CompilerResults> CompileCSharp(string sourceFileName, C`
`608`	`608`	`if (flags.HasFlag(CompilerOptions.ProcessXmlDoc))`
`609`	`609`	`{`
`610`	`610`	`otherOptions += $"-doc:\"{Path.ChangeExtension(results.PathToAssembly, ".xml")}\" ";`
	`611`	`+ noWarn.Add("CS1591"); // Missing XML comment for publicly visible type or member 'Type_or_Member'`
`611`	`612`	`}`
`612`	`613`
`613`	`614`	`if (flags.HasFlag(CompilerOptions.CheckForOverflowUnderflow))`
`@@ -622,7 +623,6 @@ public static async Task<CompilerResults> CompileCSharp(string sourceFileName, C`
`622`	`623`	`if (preprocessorSymbols.Count > 0)`
`623`	`624`	`{`
`624`	`625`	`otherOptions += " \"-d:" + string.Join(";", preprocessorSymbols) + "\" ";`
`625`		`- noWarn.Add("CS1591");`
`626`	`626`	`}`
`627`	`627`
`628`	`628`	`if (noWarn.Count > 0)`