Rename option to "UseObjectCreationOfGenericTypeParameter"

Author: siegfriedpammer

ICSharpCode.Decompiler/CSharp/Transforms/ReplaceMethodCallsWithOperators.cs

@@ -138,7 +138,7 @@ void ProcessInvocationExpression(InvocationExpression invocationExpression)
 				break;
 				*/
 				case "System.Activator.CreateInstance":
-					if (context.Settings.GenericTypeInstantiation &&
+					if (context.Settings.UseObjectCreationOfGenericTypeParameter &&
 						arguments.Length == 0 &&
 						method.TypeArguments.Count == 1 &&
 						IsInstantiableTypeParameter(method.TypeArguments[0]))

ICSharpCode.Decompiler/DecompilerSettings.cs

@@ -63,7 +63,7 @@ public void SetLanguageVersion(CSharp.LanguageVersion languageVersion)
 				liftNullables = false;
 				yieldReturn = false;
 				useImplicitMethodGroupConversion = false;
-				genericTypeInstantiation = false;
+				useObjectCreationOfGenericTypeParameter = false;
 			}
 			if (languageVersion < CSharp.LanguageVersion.CSharp3)
 			{
@@ -211,7 +211,7 @@ public CSharp.LanguageVersion GetMinimumRequiredVersion()
 			if (anonymousTypes || objectCollectionInitializers || automaticProperties
 				|| queryExpressions || expressionTrees)
 				return CSharp.LanguageVersion.CSharp3;
-			if (anonymousMethods || liftNullables || yieldReturn || useImplicitMethodGroupConversion || genericTypeInstantiation)
+			if (anonymousMethods || liftNullables || yieldReturn || useImplicitMethodGroupConversion || useObjectCreationOfGenericTypeParameter)
 				return CSharp.LanguageVersion.CSharp2;
 			return CSharp.LanguageVersion.CSharp1;
 		}
@@ -987,21 +987,21 @@ public bool UseImplicitMethodGroupConversion {
 			}
 		}
 
-		bool genericTypeInstantiation = true;
+		bool useObjectCreationOfGenericTypeParameter = true;
 
 		/// <summary>
-		/// Gets/Sets whether to use generic type instantiation for generic types with <c>new()</c> constraint.
+		/// Gets/Sets whether to use object creation expressions for generic types with <c>new()</c> constraint.
 		/// true: <c>T t = new T();</c>
 		/// false: <c>T t = Activator.CreateInstance&lt;T&gt;()</c>
 		/// </summary>
 		[Category("C# 2.0 / VS 2005")]
-		[Description("DecompilerSettings.GenericTypeInstantiation")]
-		public bool GenericTypeInstantiation {
-			get { return genericTypeInstantiation; }
+		[Description("DecompilerSettings.UseObjectCreationOfGenericTypeParameter")]
+		public bool UseObjectCreationOfGenericTypeParameter {
+			get { return useObjectCreationOfGenericTypeParameter; }
 			set {
-				if (genericTypeInstantiation != value)
+				if (useObjectCreationOfGenericTypeParameter != value)
 				{
-					genericTypeInstantiation = value;
+					useObjectCreationOfGenericTypeParameter = value;
 					OnPropertyChanged();
 				}
 			}

ICSharpCode.Decompiler/IL/Transforms/ExpressionTransforms.cs

@@ -532,7 +532,10 @@ protected internal override void VisitIfInstruction(IfInstruction inst)
 			inst.Condition.AcceptVisitor(this);
 
 			if (new NullableLiftingTransform(context).Run(inst))
+			{
+				context.Step("NullableLiftingTransform", inst);
 				return;
+			}
 
 			if (TransformDynamicAddAssignOrRemoveAssign(inst))
 				return;

ICSharpCode.Decompiler/IL/Transforms/TransformCollectionAndObjectInitializers.cs

@@ -76,6 +76,10 @@ void IStatementTransform.Run(Block block, int pos, StatementTransformContext con
 					instType = defaultVal.Type;
 					break;
 				case Call c when c.Method.FullNameIs("System.Activator", "CreateInstance") && c.Method.TypeArguments.Count == 1:
+					if (!context.Settings.UseObjectCreationOfGenericTypeParameter)
+					{
+						return;
+					}
 					instType = c.Method.TypeArguments[0];
 					blockKind = BlockKind.ObjectInitializer;
 					break;