#3486: Remove XML serialization from DecompilerSettings in ILSpy

Author: siegfriedpammer

ILSpy/Options/DecompilerSettings.cs

@@ -56,15 +56,5 @@ public void LoadFromXml(XElement section)
 					p.SetValue(this, value.Value);
 			}
 		}
-
-		public new DecompilerSettings Clone()
-		{
-			var section = SaveToXml();
-
-			var newSettings = new DecompilerSettings();
-			newSettings.LoadFromXml(section);
-
-			return newSettings;
-		}
 	}
 }

ILSpy/Search/SearchPane.xaml.cs

@@ -478,7 +478,7 @@ Regex CreateRegex(string s)
 				if (!Enum.TryParse(this.languageVersion?.Version, out Decompiler.CSharp.LanguageVersion languageVersion))
 					languageVersion = Decompiler.CSharp.LanguageVersion.Latest;
 				decompilerSettings.SetLanguageVersion(languageVersion);
-				request.DecompilerSettings = settingsService.DecompilerSettings.Clone();
+				request.DecompilerSettings = decompilerSettings;
 
 				return request;
 			}