Merge pull request #3533 from MSchmoecker/fix-disabled-optional-arguments

Fix incorrect argument removal if OptionalArguments is false

Author: siegfriedpammer

ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj

@@ -252,6 +252,7 @@
     <Compile Include="TestCases\Pretty\ConstantsTests.cs" />
     <Compile Include="TestCases\Pretty\CS73_StackAllocInitializers.cs" />
     <Compile Include="TestCases\Pretty\OptionalArguments.cs" />
+    <Compile Include="TestCases\Pretty\OptionalArgumentsDisabled.cs" />
     <Compile Include="TestCases\Pretty\CustomShortCircuitOperators.cs" />
     <Compile Include="TestCases\Pretty\ReduceNesting.cs" />
     <Compile Include="TestCases\Pretty\InterfaceTests.cs" />

ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs

@@ -599,6 +599,17 @@ public async Task OptionalArguments([ValueSource(nameof(defaultOptions))] Compil
 			await RunForLibrary(cscOptions: cscOptions);
 		}
 
+		[Test]
+		public async Task OptionalArgumentsDisabled([ValueSource(nameof(defaultOptions))] CompilerOptions cscOptions)
+		{
+			await RunForLibrary(
+				cscOptions: cscOptions,
+				configureDecompiler: settings => {
+					settings.OptionalArguments = false;
+				}
+			);
+		}
+
 		[Test]
 		public async Task Comparisons([ValueSource(nameof(defaultOptions))] CompilerOptions cscOptions)
 		{

ICSharpCode.Decompiler.Tests/TestCases/Pretty/OptionalArgumentsDisabled.cs

@@ -0,0 +1,19 @@
+namespace ICSharpCode.Decompiler.Tests.TestCases.Pretty
+{
+	public class OptionalArgumentsDisabled
+	{
+		public void Test()
+		{
+			MixedArguments("123", 0, 0);
+			OnlyOptionalArguments(0, 0);
+		}
+
+		public void MixedArguments(string msg, int a = 0, int b = 0)
+		{
+		}
+
+		public void OnlyOptionalArguments(int a = 0, int b = 0)
+		{
+		}
+	}
+}

ICSharpCode.Decompiler/CSharp/CallBuilder.cs

@@ -967,7 +967,8 @@ private ArgumentList BuildArgumentList(ExpectedTargetDetails expectedTargetDetai
 				}
 				else
 				{
-					firstOptionalArgumentIndex = -2;
+					if (firstOptionalArgumentIndex != -1)
+						firstOptionalArgumentIndex = -2;
 				}
 				if (expressionBuilder.settings.ExpandParamsArguments && parameter.IsParams && i + 1 == callArguments.Count && argumentToParameterMap == null)
 				{