#3367: Extend range check to support negative integers.

siegfriedpammer · siegfriedpammer · commit 7218a63a4667 · 2025-01-15T21:10:19.000+01:00
diff --git a/ICSharpCode.Decompiler/IL/Transforms/EarlyExpressionTransforms.cs b/ICSharpCode.Decompiler/IL/Transforms/EarlyExpressionTransforms.cs
@@ -213,9 +213,9 @@ bool TransformDecimalCtorToConstant(NewObj inst, out LdcDecimal result)
 				int lo, mid, hi, isNegative, scale;
 				if (args[0].MatchLdcI4(out lo) && args[1].MatchLdcI4(out mid) &&
 					args[2].MatchLdcI4(out hi) && args[3].MatchLdcI4(out isNegative) &&
-					args[4].MatchLdcI4(out scale) && scale <= 28)
+					args[4].MatchLdcI4(out scale) && unchecked((byte)scale) <= 28)
 				{
-					result = new LdcDecimal(new decimal(lo, mid, hi, isNegative != 0, (byte)scale));
+					result = new LdcDecimal(new decimal(lo, mid, hi, isNegative != 0, unchecked((byte)scale)));
 					return true;
 				}
 			}

Original file line number	Diff line number	Diff line change
`@@ -213,9 +213,9 @@ bool TransformDecimalCtorToConstant(NewObj inst, out LdcDecimal result)`
`213`	`213`	`int lo, mid, hi, isNegative, scale;`
`214`	`214`	`if (args[0].MatchLdcI4(out lo) && args[1].MatchLdcI4(out mid) &&`
`215`	`215`	`args[2].MatchLdcI4(out hi) && args[3].MatchLdcI4(out isNegative) &&`
`216`		`- args[4].MatchLdcI4(out scale) && scale <= 28)`
	`216`	`+ args[4].MatchLdcI4(out scale) && unchecked((byte)scale) <= 28)`
`217`	`217`	`{`
`218`		`- result = new LdcDecimal(new decimal(lo, mid, hi, isNegative != 0, (byte)scale));`
	`218`	`+ result = new LdcDecimal(new decimal(lo, mid, hi, isNegative != 0, unchecked((byte)scale)));`
`219`	`219`	`return true;`
`220`	`220`	`}`
`221`	`221`	`}`