Rename ITypeDefinition.HasExtensionMethods to ITypeDefinition.HasExtensions

Author: siegfriedpammer

ICSharpCode.Decompiler.Tests/TypeSystem/TypeSystemLoaderTests.cs

@@ -1496,7 +1496,7 @@ public void ExtensionMethodTest()
 			Assert.That(method.IsExtensionMethod);
 			Assert.That(method.ReducedFrom, Is.Null);
 
-			Assert.That(type.HasExtensionMethods);
+			Assert.That(type.HasExtensions);
 		}
 
 		[Test]

ICSharpCode.Decompiler/CSharp/Resolver/CSharpResolver.cs

@@ -2215,7 +2215,7 @@ IEnumerable<IMethod> GetExtensionMethods(MemberLookup lookup, INamespace ns)
 			// TODO: maybe make this a property on INamespace?
 			return
 				from c in ns.Types
-				where c.IsStatic && c.HasExtensionMethods && c.TypeParameters.Count == 0 && lookup.IsAccessible(c, false)
+				where c.IsStatic && c.HasExtensions && c.TypeParameters.Count == 0 && lookup.IsAccessible(c, false)
 				from m in c.Methods
 				where m.IsExtensionMethod
 				select m;

ICSharpCode.Decompiler/TypeSystem/ITypeDefinition.cs

@@ -71,10 +71,10 @@ public interface ITypeDefinition : ITypeDefinitionOrUnknown, IType, IEntity
 		new IType? DeclaringType { get; } // solves ambiguity between IType.DeclaringType and IEntity.DeclaringType
 
 		/// <summary>
-		/// Gets whether this type contains extension methods.
+		/// Gets whether this type contains extension methods or C# 14 extensions.
 		/// </summary>
-		/// <remarks>This property is used to speed up the search for extension methods.</remarks>
-		bool HasExtensionMethods { get; }
+		/// <remarks>This property is used to speed up the search for extension members.</remarks>
+		bool HasExtensions { get; }
 
 		/// <summary>
 		/// The nullability specified in the [NullableContext] attribute on the type.

ICSharpCode.Decompiler/TypeSystem/Implementation/MetadataTypeDefinition.cs

@@ -48,7 +48,7 @@ sealed class MetadataTypeDefinition : ITypeDefinition
 		public IReadOnlyList<ITypeParameter> TypeParameters { get; }
 		public KnownTypeCode KnownTypeCode { get; }
 		public IType EnumUnderlyingType { get; }
-		public bool HasExtensionMethods { get; }
+		public bool HasExtensions { get; }
 		public Nullability NullableContext { get; }
 
 		// lazy-loaded:
@@ -132,7 +132,7 @@ internal MetadataTypeDefinition(MetadataModule module, TypeDefinitionHandle hand
 			else
 			{
 				this.Kind = TypeKind.Class;
-				this.HasExtensionMethods = this.IsStatic
+				this.HasExtensions = this.IsStatic
 					&& (module.TypeSystemOptions & TypeSystemOptions.ExtensionMethods) == TypeSystemOptions.ExtensionMethods
 					&& td.GetCustomAttributes().HasKnownAttribute(metadata, KnownAttribute.Extension);
 			}

ICSharpCode.Decompiler/TypeSystem/Implementation/MinimalCorlib.cs

@@ -173,7 +173,7 @@ public CorlibTypeDefinition(MinimalCorlib corlib, KnownTypeCode typeCode)
 			IType IType.DeclaringType => null;
 			IType IEntity.DeclaringType => null;
 
-			bool ITypeDefinition.HasExtensionMethods => false;
+			bool ITypeDefinition.HasExtensions => false;
 			bool ITypeDefinition.IsReadOnly => false;
 
 			TypeKind IType.Kind => typeKind;

ICSharpCode.ILSpyX/Analyzers/Builtin/TypeExtensionMethodsAnalyzer.cs

@@ -46,7 +46,7 @@ public IEnumerable<ISymbol> Analyze(ISymbol analyzedSymbol, AnalyzerContext cont
 
 		IEnumerable<IEntity> ScanType(ITypeDefinition analyzedType, ITypeDefinition type, AnalyzerContext context)
 		{
-			if (!type.HasExtensionMethods)
+			if (!type.HasExtensions)
 				yield break;
 
 			if (analyzedType.ParentModule?.MetadataFile == null)