Merge pull request #3484 from ds5678/issue3483

Add configuration option to check for overflow and underflow

Author: siegfriedpammer

ICSharpCode.Decompiler.Tests/Helpers/Tester.cs

@@ -69,6 +69,7 @@ public enum CompilerOptions
 		UseTestRunner = 0x4000,
 		NullableEnable = 0x8000,
 		ReferenceUnsafe = 0x10000,
+		CheckForOverflowUnderflow = 0x20000,
 		UseMcsMask = UseMcs2_6_4 | UseMcs5_23,
 		UseRoslynMask = UseRoslyn1_3_2 | UseRoslyn2_10_0 | UseRoslyn3_11_0 | UseRoslynLatest
 	}
@@ -543,6 +544,16 @@ public static async Task<CompilerResults> CompileCSharp(string sourceFileName, C
 				{
 					otherOptions += "-platform:anycpu ";
 				}
+
+				if (flags.HasFlag(CompilerOptions.CheckForOverflowUnderflow))
+				{
+					otherOptions += "-checked+ ";
+				}
+				else
+				{
+					otherOptions += "-checked- ";
+				}
+
 				if (preprocessorSymbols.Count > 0)
 				{
 					otherOptions += " \"-d:" + string.Join(";", preprocessorSymbols) + "\" ";

ICSharpCode.Decompiler.Tests/ICSharpCode.Decompiler.Tests.csproj

@@ -141,9 +141,10 @@
     <Compile Include="TestCases\Pretty\Comparisons.cs" />
     <Compile Include="TestCases\Pretty\GloballyQualifiedTypeInStringInterpolation.cs" />
     <Compile Include="TestCases\Pretty\Issue3406.cs" />
-    <Compile Include="TestCases\Pretty\PointerArithmetic.cs" />
     <Compile Include="TestCases\Pretty\Issue3439.cs" />
     <Compile Include="TestCases\Pretty\Issue3442.cs" />
+    <Compile Include="TestCases\Pretty\Issue3483.cs" />
+    <Compile Include="TestCases\Pretty\PointerArithmetic.cs" />
     <None Include="TestCases\VBPretty\VBAutomaticEvents.vb" />
     <Compile Include="TestCases\VBPretty\VBAutomaticEvents.cs" />
     <Compile Include="TestCases\VBPretty\VBNonGenericForEach.cs" />

ICSharpCode.Decompiler.Tests/PrettyTestRunner.cs

@@ -635,6 +635,12 @@ public async Task Issue3442([ValueSource(nameof(defaultOptions))] CompilerOption
 			await RunForLibrary(cscOptions: cscOptions);
 		}
 
+		[Test]
+		public async Task Issue3483([ValueSource(nameof(defaultOptions))] CompilerOptions cscOptions)
+		{
+			await RunForLibrary(cscOptions: cscOptions | CompilerOptions.CheckForOverflowUnderflow, configureDecompiler: settings => settings.CheckForOverflowUnderflow = true);
+		}
+
 		[Test]
 		public async Task AssemblyCustomAttributes([ValueSource(nameof(defaultOptions))] CompilerOptions cscOptions)
 		{

ICSharpCode.Decompiler.Tests/TestCases/Pretty/Issue3483.cs

@@ -0,0 +1,44 @@
+namespace ICSharpCode.Decompiler.Tests.TestCases.Pretty
+{
+	internal static class Issue3483
+	{
+		public static int Add_Checked(int x, int y)
+		{
+			return x + y;
+		}
+		public static int Add_Unchecked(int x, int y)
+		{
+			return unchecked(x + y);
+		}
+		public static int Add_CheckedAndUnchecked_1(int x, int y, int z)
+		{
+			return x + unchecked(y + z);
+		}
+		public static int Add_CheckedAndUnchecked_2(int x, int y, int z)
+		{
+			unchecked
+			{
+				return x + checked(y + z);
+			}
+		}
+		public static uint Cast_Checked(int x)
+		{
+			return (uint)x;
+		}
+		public static uint Cast_Unchecked(int x)
+		{
+			return unchecked((uint)x);
+		}
+		public static int Cast_CheckedAndUnchecked_1(int x)
+		{
+			return (int)unchecked((uint)x);
+		}
+		public static int Cast_CheckedAndUnchecked_2(int x)
+		{
+			unchecked
+			{
+				return (int)checked((uint)x);
+			}
+		}
+	}
+}

ICSharpCode.Decompiler/CSharp/ProjectDecompiler/IProjectInfoProvider.cs

@@ -39,6 +39,11 @@ public interface IProjectInfoProvider
 		/// </summary>
 		LanguageVersion LanguageVersion { get; }
 
+		/// <summary>
+		/// Check for overflow and underflow in operators.
+		/// </summary>
+		bool CheckForOverflowUnderflow { get; }
+
 		/// <summary>
 		/// Gets the unique ID of the project.
 		/// </summary>

ICSharpCode.Decompiler/CSharp/ProjectDecompiler/ProjectFileWriterDefault.cs

@@ -98,6 +98,7 @@ public void Write(
 
 				w.WriteElementString("OutputType", outputType);
 				w.WriteElementString("LangVersion", project.LanguageVersion.ToString().Replace("CSharp", "").Replace('_', '.'));
+				w.WriteElementString("CheckForOverflowUnderflow", project.CheckForOverflowUnderflow ? "true" : "false");
 
 				w.WriteElementString("AssemblyName", module.Name);
 				if (targetFramework.Identifier != null)

ICSharpCode.Decompiler/CSharp/ProjectDecompiler/ProjectFileWriterSdkStyle.cs

@@ -192,6 +192,7 @@ static void WriteProjectInfo(XmlTextWriter xml, IProjectInfoProvider project)
 		{
 			xml.WriteElementString("LangVersion", project.LanguageVersion.ToString().Replace("CSharp", "").Replace('_', '.'));
 			xml.WriteElementString("AllowUnsafeBlocks", TrueString);
+			xml.WriteElementString("CheckForOverflowUnderflow", project.CheckForOverflowUnderflow ? TrueString : FalseString);
 
 			if (project.StrongNameKeyFile != null)
 			{

ICSharpCode.Decompiler/CSharp/ProjectDecompiler/WholeProjectDecompiler.cs

@@ -68,6 +68,8 @@ public LanguageVersion LanguageVersion {
 			}
 		}
 
+		bool IProjectInfoProvider.CheckForOverflowUnderflow => Settings.CheckForOverflowUnderflow;
+
 		public IAssemblyResolver AssemblyResolver { get; }
 
 		public AssemblyReferenceClassifier AssemblyReferenceClassifier { get; }

ICSharpCode.Decompiler/CSharp/Transforms/AddCheckedBlocks.cs

@@ -252,8 +252,14 @@ public void Run(AstNode node, TransformContext context)
 			else
 			{
 				Result r = GetResultFromBlock(block);
-				if (r.NodesToInsertInUncheckedContext != null)
-					r.NodesToInsertInUncheckedContext.Insert();
+				if (context.DecompileRun.Settings.CheckForOverflowUnderflow)
+				{
+					r.NodesToInsertInCheckedContext?.Insert();
+				}
+				else
+				{
+					r.NodesToInsertInUncheckedContext?.Insert();
+				}
 			}
 		}
 

ICSharpCode.Decompiler/DecompilerSettings.cs

@@ -2185,6 +2185,24 @@ public bool SortCustomAttributes {
 			}
 		}
 
+		bool checkForOverflowUnderflow = false;
+
+		/// <summary>
+		/// Check for overflow and underflow in operators.
+		/// </summary>
+		[Category("DecompilerSettings.Other")]
+		[Description("DecompilerSettings.CheckForOverflowUnderflow")]
+		public bool CheckForOverflowUnderflow {
+			get { return checkForOverflowUnderflow; }
+			set {
+				if (checkForOverflowUnderflow != value)
+				{
+					checkForOverflowUnderflow = value;
+					OnPropertyChanged();
+				}
+			}
+		}
+
 		CSharpFormattingOptions csharpFormattingOptions;
 
 		[Browsable(false)]