PR #601: pass tests that are within time tolerance

piksel · web-flow · commit 6e95ec221fe0 · 2021-03-14T16:26:10.000+01:00
diff --git a/test/ICSharpCode.SharpZipLib.Tests/Zip/FastZipHandling.cs b/test/ICSharpCode.SharpZipLib.Tests/Zip/FastZipHandling.cs
@@ -750,7 +750,9 @@ public void ExtractZipShouldSetTimeOnFilesFromConstructorTimeSetting(TimeSetting
 				fastZip.ExtractZip(archiveStream, extractDir.Fullpath, FastZip.Overwrite.Always, 
 					_ => true, "", "", true, true, false);
 				var fi = new FileInfo(Path.Combine(extractDir.Fullpath, SingleEntryFileName));
-				Assert.AreEqual(targetTime, FileTimeFromTimeSetting(fi, timeSetting));
+				var actualTime = FileTimeFromTimeSetting(fi, timeSetting);
+				// Assert that the time is within +/- 2s of the target time to allow for timing/rounding discrepancies
+				Assert.LessOrEqual(Math.Abs((targetTime - actualTime).TotalSeconds), 2);
 			}
 		}
 

Original file line number	Diff line number	Diff line change
`@@ -750,7 +750,9 @@ public void ExtractZipShouldSetTimeOnFilesFromConstructorTimeSetting(TimeSetting`
`750`	`750`	`fastZip.ExtractZip(archiveStream, extractDir.Fullpath, FastZip.Overwrite.Always,`
`751`	`751`	`_ => true, "", "", true, true, false);`
`752`	`752`	`var fi = new FileInfo(Path.Combine(extractDir.Fullpath, SingleEntryFileName));`
`753`		`- Assert.AreEqual(targetTime, FileTimeFromTimeSetting(fi, timeSetting));`
	`753`	`+ var actualTime = FileTimeFromTimeSetting(fi, timeSetting);`
	`754`	`+ // Assert that the time is within +/- 2s of the target time to allow for timing/rounding discrepancies`
	`755`	`+ Assert.LessOrEqual(Math.Abs((targetTime - actualTime).TotalSeconds), 2);`
`754`	`756`	`}`
`755`	`757`	`}`
`756`	`758`